Skip to content

chore(linter): Add message to diagnostics optimizations debug assert#18218

Merged
Sysix merged 1 commit intooxc-project:mainfrom
yue4u:add-into-to-runtime-diagnostics-assert
Jan 19, 2026
Merged

chore(linter): Add message to diagnostics optimizations debug assert#18218
Sysix merged 1 commit intooxc-project:mainfrom
yue4u:add-into-to-runtime-diagnostics-assert

Conversation

@yue4u
Copy link
Copy Markdown
Contributor

@yue4u yue4u commented Jan 19, 2026

Changing run() into run_once() during implementation will cause this assert to be triggered, but the message is not pointing to a clear direction.
It took me a while to debug this for #17688.

rebase: fix commit message typo

@yue4u yue4u requested a review from camc314 as a code owner January 19, 2026 07:23
@github-actions github-actions Bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 19, 2026
@yue4u yue4u force-pushed the add-into-to-runtime-diagnostics-assert branch from 37449b5 to 8d56c43 Compare January 19, 2026 07:32
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing yue4u:add-into-to-runtime-diagnostics-assert (8d56c43) with main (1b199af)1

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks2

Footnotes

  1. No successful run was found on main (1aafdd9) during the generation of this report, so 1b199af was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix merged commit 78ca6ee into oxc-project:main Jan 19, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants