Skip to content

fix(linter): cross_module of LintService not being enabled despite enabled import plugin#10597

Merged
Sysix merged 2 commits intooxc-project:mainfrom
ulrichstark:fix-cross-module-of-lint-service-not-being-enabled
Apr 25, 2025
Merged

fix(linter): cross_module of LintService not being enabled despite enabled import plugin#10597
Sysix merged 2 commits intooxc-project:mainfrom
ulrichstark:fix-cross-module-of-lint-service-not-being-enabled

Conversation

@ulrichstark
Copy link
Contributor

Running oxlint --import-plugin with no oxlintrc.json didn't enable cross_module of LintService, because use_nested_config was true and nested_configs empty in that case. This leads to rules like import/no-cycle not working.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Apr 24, 2025
Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you ❤️

@Sysix Sysix merged commit 723b4c6 into oxc-project:main Apr 25, 2025
13 checks passed
@ulrichstark ulrichstark deleted the fix-cross-module-of-lint-service-not-being-enabled branch April 26, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants