-
-
Notifications
You must be signed in to change notification settings - Fork 931
Closed
Labels
A-astArea - ASTArea - ASTC-bugCategory - BugCategory - Buggood first issueExperience Level - Good for newcomersExperience Level - Good for newcomers
Description
CallExpression currently has arguments before callee:
oxc/crates/oxc_ast/src/ast/js.rs
Lines 601 to 608 in 4e818a4
| pub struct CallExpression<'a> { | |
| #[serde(flatten)] | |
| pub span: Span, | |
| pub arguments: Vec<'a, Argument<'a>>, | |
| pub callee: Expression<'a>, | |
| pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>, | |
| pub optional: bool, // for optional chaining | |
| } |
Is there a reason for this? It seems like this field order would make more sense:
pub struct CallExpression<'a> {
#[serde(flatten)]
pub span: Span,
pub callee: Expression<'a>,
pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
pub arguments: Vec<'a, Argument<'a>>,
pub optional: bool, // for optional chaining
} Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-astArea - ASTArea - ASTC-bugCategory - BugCategory - Buggood first issueExperience Level - Good for newcomersExperience Level - Good for newcomers
Type
Fields
Give feedbackPriority
None yet