semantic: directly record real node ID when adding a scope to the scope-tree

From https://github.com/oxc-project/oxc/pull/4208#discussion_r1674797228:

> Once https://github.com/oxc-project/oxc/pull/4203 is merged, node IDs will be generated before scope is created, so we can add node_id to params of this function, and push the actual AstNodeId here. Then we can remove set_node_id.

In particular, this is about refactoring the logic here below and getting rid of the dummy node ID:
https://github.com/oxc-project/oxc/blob/be82c286d63f4660cde7df590a9586eec284232f/crates/oxc_semantic/src/scope.rs#L182-L195

	pub fn add_scope(&mut self, parent_id: Option<ScopeId>, flags: ScopeFlags) -> ScopeId {
	let scope_id = self.parent_ids.push(parent_id);
	_ = self.child_ids.push(vec![]);
	_ = self.flags.push(flags);
	_ = self.bindings.push(Bindings::default());
	_ = self.node_ids.push(AstNodeId::dummy());

	// Set this scope as child of parent scope.
	if let Some(parent_id) = parent_id {
	self.child_ids[parent_id].push(scope_id);
	}

	scope_id
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

semantic: directly record real node ID when adding a scope to the scope-tree #4234

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Uh oh!

semantic: directly record real node ID when adding a scope to the scope-tree #4234

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions