-
-
Notifications
You must be signed in to change notification settings - Fork 933
Closed
Labels
Description
oxc/crates/oxc_linter/src/rules/eslint/max_lines.rs
Lines 134 to 140 in 1cca2a8
| ctx.diagnostic(max_lines_diagnostic( | |
| &error, | |
| Span::new( | |
| u32::try_from(start).unwrap_or(u32::MIN), | |
| u32::try_from(ctx.source_text().len()).unwrap_or(u32::MAX), | |
| ), | |
| )); |
currently, it will lot out every extra line to the console.
if you have a large file. e.g. 1000+. it is a lot of (im my opinion) unneccessary noise in the console.
i think it is worth considering either
- reporting the diagnostic at the first character of the file
- reporting the diagnostic at the first character of the first line that goes over the limt
this will make the linting diagnostics more readable for the end user
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackPriority
None yet