Skip to content

transformer: improve the implementation of eliminating type-only exports  #3827

New issue
New issue
Closed
#4321
Closed
transformer: improve the implementation of eliminating type-only exports #3827
#4321
Assignees
Dunqing
Labels
A-transformerArea - Transformer / TranspilerC-performanceCategory - Solution not expected to change functional behavior, only performance
@Dunqing

Description

@Dunqing
Dunqing
opened on Jun 22, 2024

#3820 was added IdentifierReference to ExportSpecifier. This means we no longer need to collect type-only import binding names.

oxc/crates/oxc_transformer/src/typescript/annotations.rs

Lines 143 to 146 in 4456034

if is_type || s.import_kind.is_type() {
self.type_identifier_names.insert(s.local.name.clone());
return false;
}

We just need to check if the import binding has a type reference.

But, unfortunately, we're currently stuck due to issue #3826. Once it's fixed, I'll be able to start working on this.

Metadata

Metadata

Assignees

Labels

A-transformerArea - Transformer / TranspilerC-performanceCategory - Solution not expected to change functional behavior, only performance

Type

No type

Fields

Priority

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions