The manual AssignmentTargetRest should be updated to use argument field.

Thanks for spotting this. Damn! I thought I'd got it all correct in the end (and it was a bit of a battle).

I struggled a bit because I wasn't sure what AST type was our target for what we're trying to match. I was comparing to Acorn's output as produced by https://ast.sxzz.moe/ but that doesn't include the TS-related fields. What parser are we comparing to, and is that parser's output available on any playground/AST explorer?

On this specific one, could you possibly provide some source code which produces the incorrect AST? From looking at the Serde impls, it should already be renaming the target field to argument.

oxc/crates/oxc_ast/src/ast/js.rs

Lines 1040 to 1045 in 32303b2

    
           pub struct AssignmentTargetRest<'a> { 
        
               #[cfg_attr(feature = "serde", serde(flatten))] 
        
               pub span: Span, 
        
               #[cfg_attr(feature = "serde", serde(rename = "argument"))] 
        
               pub target: AssignmentTarget<'a>, 
        
           }

Probably I'm missing something...

	pub struct AssignmentTargetRest<'a> {
	#[cfg_attr(feature = "serde", serde(flatten))]
	pub span: Span,
	#[cfg_attr(feature = "serde", serde(rename = "argument"))]
	pub target: AssignmentTarget<'a>,
	}

Uh oh!

AssignmentTargetRest should have argument field in JSON AST #2657

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions

`AssignmentTargetRest` should have `argument` field in JSON AST #2657