feat(isolated-declarations): support inferring ParenthesizedExpression (#3769)

Dunqing · Dunqing · commit b38c34dfce82 · 2024-06-19T15:43:21.000Z
diff --git a/crates/oxc_isolated_declarations/src/inferrer.rs b/crates/oxc_isolated_declarations/src/inferrer.rs
@@ -52,16 +52,15 @@ impl<'a> IsolatedDeclarations<'a> {
                 self.error(inferred_type_of_class_expression(expr.span));
                 Some(self.ast.ts_unknown_keyword(SPAN))
             }
+            Expression::ParenthesizedExpression(expr) => {
+                self.infer_type_from_expression(&expr.expression)
+            }
             Expression::TSNonNullExpression(expr) => {
                 self.infer_type_from_expression(&expr.expression)
             }
             Expression::TSSatisfiesExpression(expr) => {
                 self.infer_type_from_expression(&expr.expression)
             }
-            Expression::TSInstantiationExpression(_expr) => {
-                unreachable!();
-                // infer_type_from_expression(ctx, &expr.expression)
-            }
             Expression::TSTypeAssertion(expr) => Some(self.ast.copy(&expr.type_annotation)),
             _ => None,
         }
diff --git a/crates/oxc_isolated_declarations/tests/fixtures/infer-expression.ts b/crates/oxc_isolated_declarations/tests/fixtures/infer-expression.ts
@@ -0,0 +1,5 @@
+// ParenthesizedExpression
+const n = (0);
+const s = ("");
+const t = (``);
+const b = (true);
diff --git a/crates/oxc_isolated_declarations/tests/snapshots/infer-expression.snap b/crates/oxc_isolated_declarations/tests/snapshots/infer-expression.snap
@@ -0,0 +1,10 @@
+---
+source: crates/oxc_isolated_declarations/tests/mod.rs
+input_file: crates/oxc_isolated_declarations/tests/fixtures/infer-expression.ts
+---
+==================== .D.TS ====================
+
+declare const n: number;
+declare const s: string;
+declare const t: string;
+declare const b: boolean;

Original file line number	Diff line number	Diff line change
`@@ -52,16 +52,15 @@ impl<'a> IsolatedDeclarations<'a> {`
`52`	`52`	`self.error(inferred_type_of_class_expression(expr.span));`
`53`	`53`	`Some(self.ast.ts_unknown_keyword(SPAN))`
`54`	`54`	`}`
	`55`	`+ Expression::ParenthesizedExpression(expr) => {`
	`56`	`+ self.infer_type_from_expression(&expr.expression)`
	`57`	`+ }`
`55`	`58`	`Expression::TSNonNullExpression(expr) => {`
`56`	`59`	`self.infer_type_from_expression(&expr.expression)`
`57`	`60`	`}`
`58`	`61`	`Expression::TSSatisfiesExpression(expr) => {`
`59`	`62`	`self.infer_type_from_expression(&expr.expression)`
`60`	`63`	`}`
`61`		`- Expression::TSInstantiationExpression(_expr) => {`
`62`		`- unreachable!();`
`63`		`- // infer_type_from_expression(ctx, &expr.expression)`
`64`		`- }`
`65`	`64`	`Expression::TSTypeAssertion(expr) => Some(self.ast.copy(&expr.type_annotation)),`
`66`	`65`	`_ => None,`
`67`	`66`	`}`