fix: use a tag in context menu instead of button for editors in ctx menu #11854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
suggested changes
Nov 5, 2024
Contributor
kulmann
left a comment
There was a problem hiding this comment.
please add a changelog item, as this bug was part of a release.
Contributor
Author
Please have a little patience with old ppl like me :( |
Contributor
Author
|
Let's see if the e2e test are happy, they might check for button and not for a tag |
kulmann
approved these changes
Nov 5, 2024
Contributor
kulmann
left a comment
There was a problem hiding this comment.
Thanks for the speedy fix! 🏎️
485ac87 to
7293fdf
Compare
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: