fix: folder size mismatch #11814
Merged
fix: folder size mismatch #11814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the size mismatch between a folder in the file list and the accumulated size inside the folder beneath the file list. The latter now takes the size of the current folder and only falls back to manually accumulating the size if no current folder given. Also removes the `totalResourcesSize` computed from the resource store because it's only used in one place and we don't want to encourage others to use this method of calculating the current folder's size.
85c7e99 to
446edcd
Compare
Removes the file size assertion step because the calculated size by the server might differ slightly.
446edcd to
3db9c66
Compare
|
dschmidt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the size mismatch between a folder in the file list and the accumulated size inside the folder beneath the file list.
The latter now takes the size of the current folder and only falls back to manually accumulating the size if no current folder given. Also removes the
totalResourcesSizecomputed from the resource store because it's only used in one place and we don't want to encourage others to use this method of calculating the current folder's size.fixes #11806