fix: LastModifiedDate in collaboration service#11328
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
d735e17 to
ffc1aa2
Compare
|
|
||
| lastModifiedTime := time.Now().UTC().Format(timeFormat) | ||
| if statRes.GetInfo().GetMtime() != nil { | ||
| lastModifiedTime = time.Unix(int64(statRes.GetInfo().GetMtime().GetSeconds()), 0).UTC().Format(timeFormat) |
There was a problem hiding this comment.
Why do we ignore the GetNanos() if the template supports the micro seconds? "2006-01-02T15:04:05.0000000Z"
There was a problem hiding this comment.
Nanos can be added. In the test case the Version looks like ignoring Nanos too and may change in test including Nanos. I need to double check in MS reference.
There was a problem hiding this comment.
The reva and CS3 Timestamp use the nanoseconds
https://github.com/owncloud/reva/blob/3792d6369f9d5a30d3cfade227b0de4a25d1b6bb/pkg/utils/utils.go#L193
|
Description
Fix regression in collaboration service, missing LastModifiedDate
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: