[Tests-Only] Remove unneeded phpstan ignoreErrors entry#37335
Merged
phil-davis merged 1 commit intomasterfrom May 4, 2020
Merged
[Tests-Only] Remove unneeded phpstan ignoreErrors entry#37335phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
individual-it
approved these changes
May 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #37335 +/- ##
=============================================
- Coverage 64.55% 47.78% -16.77%
=============================================
Files 1267 111 -1156
Lines 75065 10917 -64148
Branches 1331 1331
=============================================
- Hits 48458 5217 -43241
+ Misses 26215 5308 -20907
Partials 392 392
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This started happening today because that error pattern was actually a bug in
phpstan. The bug was fixed in phpstan/phpstan-src#192 and released in https://github.com/phpstan/phpstan/releases/tag/0.12.22So now our CI fails because it was expected this "error" to be reported. But it is no longer reported.
How Has This Been Tested?
CI
Types of changes
Checklist: