Skip to content

[Tests-Only] Remove unneeded phpstan ignoreErrors entry#37335

Merged
phil-davis merged 1 commit intomasterfrom
fix-phpstan-20200504
May 4, 2020
Merged

[Tests-Only] Remove unneeded phpstan ignoreErrors entry#37335
phil-davis merged 1 commit intomasterfrom
fix-phpstan-20200504

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented May 4, 2020

Description

make test-php-phpstan
composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package guzzlehttp/ringphp is abandoned, you should avoid using it. No replacement was suggested.
Package guzzlehttp/streams is abandoned, you should avoid using it. No replacement was suggested.
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Generating optimized autoload files
Composer cleaner: Removed 5 files or directories.
composer bin phpstan install --no-progress
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
php -d zend.enable_gc=0 vendor-bin/phpstan/vendor/bin/phpstan analyse --memory-limit=2G --configuration=./phpstan.neon --level=0 apps core settings lib/private lib/public ocs ocs-provider
 1367/1367 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 -- ------------------------------------------------------------------------------------------------------------ 
     Error                                                                                                       
 -- ------------------------------------------------------------------------------------------------------------ 
     Ignored error pattern #Result of function rewinddir \(void\) is used.# was not matched in reported errors.  
 -- ------------------------------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                                                                                                                        

Makefile:231: recipe for target 'test-php-phpstan' failed
make: *** [test-php-phpstan] Error 1

This started happening today because that error pattern was actually a bug in phpstan. The bug was fixed in phpstan/phpstan-src#192 and released in https://github.com/phpstan/phpstan/releases/tag/0.12.22

So now our CI fails because it was expected this "error" to be reported. But it is no longer reported.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2020

Codecov Report

Merging #37335 into master will decrease coverage by 16.76%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #37335       +/-   ##
=============================================
- Coverage     64.55%   47.78%   -16.77%     
=============================================
  Files          1267      111     -1156     
  Lines         75065    10917    -64148     
  Branches       1331     1331               
=============================================
- Hits          48458     5217    -43241     
+ Misses        26215     5308    -20907     
  Partials        392      392               
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 33.78% <ø> (-31.93%) 0.00 <ø> (-19207.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 57.75% <0.00%> (-20.41%) 0.00% <0.00%> (ø%)
...atedfilesharing/lib/Command/PollIncomingShares.php
lib/private/legacy/l10n/string.php
apps/federation/appinfo/routes.php
version.php
apps/dav/lib/Connector/Sabre/QuotaPlugin.php
core/Middleware/TwoFactorMiddleware.php
lib/public/App.php
lib/private/Preview/TXT.php
core/Command/App/Disable.php
... and 1147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9763797...44204bd. Read the comment docs.

@phil-davis phil-davis merged commit e38bb87 into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-phpstan-20200504 branch May 4, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants