Remove encryption app by DeepDiver1975 · Pull Request #35949 · owncloud/core

DeepDiver1975 · 2019-07-30T08:13:44Z

Description

As per #35777 the encryption app will be released from its own repo

How Has This Been Tested?

🤖

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

patrickjahns · 2019-07-30T09:58:53Z

This needs to be taken into account for the next releases and we shall publish the first app release

Can we make a diff between what is in here and encryption repository to be sure we have no extra/false stuff ;-)

DeepDiver1975 · 2019-07-30T10:00:14Z

This needs to be taken into account for the next releases and we shall publish the first app release

Didn't we agree on bundling it from the own repo?

phil-davis · 2019-07-30T10:33:43Z

The old core stable10 had the encryption acceptance tests in it, so they also need to be removed in this PR. I did that in the commit that I just pushed.

I diff'd the test suites between core stable10 and the encryption app not long ago. The test code and scenarios are the same in the encryption app.

patrickjahns · 2019-07-30T11:50:00Z

@DeepDiver1975

Didn't we agree on bundling it from the own repo?`

works for me - just wanted to keep a reminder in this PR to update this then in the build definitions

@phil-davis
Did you also diff the code, or only the tests?

phil-davis · 2019-07-30T11:52:58Z

Did you also diff the code, or only the tests?
I only diffed the acceptance tests

patrickjahns · 2019-07-30T11:59:53Z

There is an issue open to check code alignment owncloud/encryption#118

So the question is - should we archive the code in owncloud/encryption master and move over the code from this repository. That would give us the easiest way forward.

We then could release the app in the repo as 1.4.0 ( as we did with other apps not in the marketplace, but being bundled )

DeepDiver1975 · 2019-07-30T13:31:21Z

So the question is - should we archive the code in owncloud/encryption master and move over the code from this repository. That would give us the easiest way forward.

my understanding was that the code is more advanced in owncloud/encryption - did I miss anything?

DeepDiver1975 · 2019-08-01T06:09:33Z

my understanding was that the code is more advanced in owncloud/encryption - did I miss anything?

@patrickjahns see owncloud/encryption#118 (comment) - the code in the app is fine - no need to copy over any code from core

codecov · 2019-08-02T06:26:41Z

Codecov Report

Merging #35949 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #35949   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385

Flag	Coverage Δ
#javascript	`53.85% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c27f4f...d3ea4fc. Read the comment docs.

DeepDiver1975 · 2019-08-02T08:27:19Z

settings/ChangePassword/Controller.php:104 PhanUndeclaredClassMethod Call to method __construct from undeclared class \OCA\Encryption\Crypto\Crypt
settings/ChangePassword/Controller.php:110 PhanUndeclaredClassMethod Call to method __construct from undeclared class \OCA\Encryption\Util (Did you mean class \League\Flysystem\Util)
settings/ChangePassword/Controller.php:117 PhanUndeclaredClassMethod Call to method __construct from undeclared class \OCA\Encryption\KeyManager
settings/ChangePassword/Controller.php:122 PhanUndeclaredClassMethod Call to method __construct from undeclared class \OCA\Encryption\Session
settings/ChangePassword/Controller.php:125 PhanUndeclaredClassMethod Call to method __construct from undeclared class \OCA\Encryption\Recovery
settings/ChangePassword/Controller.php:134 PhanUndeclaredClassMethod Call to method isRecoveryKeyEnabled from undeclared class \OCA\Encryption\Recovery
settings/ChangePassword/Controller.php:139 PhanUndeclaredClassMethod Call to method checkRecoveryPassword from undeclared class \OCA\Encryption\KeyManager
settings/ChangePassword/Controller.php:140 PhanUndeclaredClassMethod Call to method isRecoveryEnabledForUser from undeclared class \OCA\Encryption\Recovery
Makefile:224: recipe for target 'test-php-phan' failed

patrickjahns · 2019-08-06T13:05:56Z

stan doesn't like you

In RobotLoader.php line 239:
                                                                               
  File or directory '/drone/src/apps/encryption/appinfo/Migrations' not found

Fixed by dropping the lines here https://github.com/owncloud/core/blob/master/phpstan.neon#L4-L5

phil-davis

LGTM - the various bits-and-pieces that reference the now-gone encryption app are tidied up.

phil-davis · 2019-08-07T14:08:15Z

No codecov came, but that is not really relevant anyway - not much can be done if a lot of code is deleted and then the average codecov percentage is different.
@patrickjahns @DeepDiver1975 merge this when drone comes back?

phil-davis · 2019-08-09T07:17:17Z

Note: this did not need to remove encryption tests from drone CI, because during the drone v0.8->v1 upgrade the new drone v1 .drone.yml was implemented without encryption test matrix entries anyway (we knew that this PR here was ready to merge!)

DeepDiver1975 added the 3 - To Review label Jul 30, 2019

DeepDiver1975 requested a review from patrickjahns July 30, 2019 08:13

DeepDiver1975 self-assigned this Jul 30, 2019

DeepDiver1975 mentioned this pull request Jul 30, 2019

Change branching model for core ... #35777

Closed

10 tasks

DeepDiver1975 changed the title ~~Bye bye enc again~~ Remove encryption app Jul 30, 2019

patrickjahns mentioned this pull request Jul 30, 2019

Setup Transifex owncloud/encryption#136

Closed

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 6306543 to 88c6708 Compare August 1, 2019 05:53

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 88c6708 to 8f1cb86 Compare August 1, 2019 06:11

owncloud deleted a comment from codecov bot Aug 1, 2019

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 8f1cb86 to 8b2ffdf Compare August 2, 2019 06:25

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 8b2ffdf to 38d83cc Compare August 6, 2019 12:40

DeepDiver1975 force-pushed the bye-bye-enc-again branch 2 times, most recently from 364b34d to 6904655 Compare August 7, 2019 07:22

phil-davis mentioned this pull request Aug 7, 2019

Replace drone matrix config by jsonnet definition #35987

Merged

11 tasks

DeepDiver1975 force-pushed the bye-bye-enc-again branch 2 times, most recently from b87ba0f to 3050aaf Compare August 7, 2019 10:00

phil-davis approved these changes Aug 7, 2019

View reviewed changes

DeepDiver1975 added 5 commits August 8, 2019 15:48

Bye-bye encryption

3fa1b95

Remove obsolete encryption integration tests

5cfcafa

Remove unused encryption controller

671ff9e

Fix translation config

ee481bd

No need to enable encryption app for testing

93ff789

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 3050aaf to 2617d36 Compare August 8, 2019 13:50

Annotate source code to make phan succeed and fix phpstan config

d3ea4fc

DeepDiver1975 force-pushed the bye-bye-enc-again branch from 2617d36 to d3ea4fc Compare August 8, 2019 14:48

DeepDiver1975 merged commit da8c171 into master Aug 9, 2019

delete-merged-branch bot deleted the bye-bye-enc-again branch August 9, 2019 07:01

phil-davis added the release:10.3.0 label Aug 13, 2019

phil-davis mentioned this pull request Aug 13, 2019

Remove unused encryption acceptance tests #36023

Merged

10 tasks

patrickjahns added the changelog-added label Aug 15, 2019

davitol mentioned this pull request Sep 3, 2019

10.3 - Changelog test Results #36142

Closed

13 tasks

Conversation

DeepDiver1975 commented Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

Uh oh!

patrickjahns commented Jul 30, 2019

Uh oh!

DeepDiver1975 commented Jul 30, 2019

Uh oh!

phil-davis commented Jul 30, 2019

Uh oh!

patrickjahns commented Jul 30, 2019

Uh oh!

phil-davis commented Jul 30, 2019

Uh oh!

patrickjahns commented Jul 30, 2019

Uh oh!

DeepDiver1975 commented Jul 30, 2019

Uh oh!

DeepDiver1975 commented Aug 1, 2019

Uh oh!

codecov bot commented Aug 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DeepDiver1975 commented Aug 2, 2019

Uh oh!

patrickjahns commented Aug 6, 2019

Uh oh!

phil-davis left a comment

Choose a reason for hiding this comment

Uh oh!

phil-davis commented Aug 7, 2019

Uh oh!

phil-davis commented Aug 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DeepDiver1975 commented Jul 30, 2019 •

edited

Loading

codecov bot commented Aug 2, 2019 •

edited

Loading