Skip to content

[stable10] Remove not longer valid update script - pre-8.1 upgrade#35781

Merged
DeepDiver1975 merged 1 commit intostable10from
stable10-remove-old-update-script
Jul 8, 2019
Merged

[stable10] Remove not longer valid update script - pre-8.1 upgrade#35781
DeepDiver1975 merged 1 commit intostable10from
stable10-remove-old-update-script

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented Jul 8, 2019 •
edited
Loading

Backport #33209

I noticed this when backporting "Introduce PHPstan" #35774 - in that PR I had to exclude this file from analysis because:

php -d zend.enable_gc=0 vendor-bin/phpstan/vendor/bin/phpstan analyse --memory-limit=2G --configuration=./phpstan.neon --level=0 apps core settings lib/private lib/public ocs ocs-provider
 1392/1392 

 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  Line   apps/files/appinfo/update.php                                                                                                   
 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  52     Function owncloud_reset_encrypted_flag not found while trying to analyse it - autoloading is probably not configured properly.  
  72     Function owncloud_reset_encrypted_flag not found.                                                                               
  79     Function owncloud_reset_encrypted_flag not found.                                                                               
 ------ --------------------------------------------------------------------------------------------------------------------------------

It is "ordinary" PHP, not a class.

Rather than trying to sort all that out, delete it.
Deleted code is debugged code.

@phil-davis phil-davis self-assigned this Jul 8, 2019
@phil-davis
Copy link
Copy Markdown
Contributor Author

phil-davis commented Jul 8, 2019

@DeepDiver1975 does it seem OK to delete this for 10.3 ?
(rather than in a major version 11)

This was referenced Jul 8, 2019
Merged
Merged
@phil-davis phil-davis force-pushed the stable10-remove-old-update-script branch from 3323b79 to dc3c059 Compare July 8, 2019 14:14
@DeepDiver1975 DeepDiver1975 merged commit 305a8ec into stable10 Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-remove-old-update-script branch July 8, 2019 17:58
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees

@phil-davis phil-davis

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-davis @DeepDiver1975 @patrickjahns