[do not merge] Demo incorrect phpunit status (PHPUnit6)#34857
Closed
phil-davis wants to merge 3 commits intomasterfrom
Closed
[do not merge] Demo incorrect phpunit status (PHPUnit6)#34857phil-davis wants to merge 3 commits intomasterfrom
phil-davis wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
https://phpunit.de/supported-versions.html We are currently using PHPunit 5.7.27 - official support finished 2018-02-02 and it ony claims to support PHP 5.6, PHP 7.0, PHP 7.1 - so there are no guarantees about what happens with PHP 7.2 and 7.3 PHPunit 6 - official support ended 2019-02-01 - it supports PHP PHP 7.0, PHP 7.1, PHP 7.2 - so that is what we could use PHPunit 7 is for PHP 7.1, PHP 7.2, PHP 7.3 and so we can only use that when we drop PHP 7.0 |
Contributor
Author
|
Keeping this here for further investigation this week, to try and understand exactly what unit test step is causing grief for the PHPUnit exit status. |
a308b5f to
49fa229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See issue for the detailed description of this problem.
Related Issue
Issue #34858
Motivation and Context
CI should reliably report red-fail when a test fails.
How Has This Been Tested?
CI