Skip to content

Move SubadminMiddleware to user_management app#30960

Merged
DeepDiver1975 merged 1 commit intomasterfrom
move-subadmin-middleware-to-user_management
Apr 3, 2018
Merged

Move SubadminMiddleware to user_management app#30960
DeepDiver1975 merged 1 commit intomasterfrom
move-subadmin-middleware-to-user_management

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Mar 29, 2018 •
edited
Loading

Description

The sub admin middleware is only used in the user management frontend.
Moving it there ....

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Mar 29, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Mar 29, 2018
@DeepDiver1975 DeepDiver1975 requested a review from PVince81 March 29, 2018 12:40
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Mar 29, 2018

works fine using this branch in core and the user_management PR owncloud-archive/user_management#16 bugfix/no-access-to-unpriviledged-users branch as a pair together.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2018 •
edited
Loading

Codecov Report

Merging #30960 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30960      +/-   ##
============================================
- Coverage      62.3%   62.29%   -0.01%     
+ Complexity    18233    18224       -9     
============================================
  Files          1141     1140       -1     
  Lines         68155    68129      -26     
  Branches       1232     1232              
============================================
- Hits          42461    42439      -22     
+ Misses        25333    25329       -4     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.46% <ø> (-0.01%) 18224 <ø> (-9)
Impacted Files Coverage Δ Complexity Δ
settings/Application.php 53.59% <ø> (+0.46%) 33 <0> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adead9...59cf400. Read the comment docs.

@DeepDiver1975
Copy link
Copy Markdown
Member Author

DeepDiver1975 commented Apr 3, 2018

works fine using this branch in core and the user_management PR owncloud-archive/user_management#16 bugfix/no-access-to-unpriviledged-users branch as a pair together.

taking as 👍

@DeepDiver1975 DeepDiver1975 merged commit ace89ed into master Apr 3, 2018
@DeepDiver1975 DeepDiver1975 deleted the move-subadmin-middleware-to-user_management branch April 3, 2018 12:05
@phil-davis phil-davis mentioned this pull request Jul 8, 2019
Merged
10 tasks
@lock
Copy link
Copy Markdown

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@DeepDiver1975 DeepDiver1975

Labels

3 - To Review

Projects

None yet

Milestone

10.0.8

Development

Successfully merging this pull request may close these issues.

2 participants

@DeepDiver1975 @phil-davis