Added code coverage using mysql by SergioBertolinSG · Pull Request #29410 · owncloud/core

SergioBertolinSG · 2017-11-02T09:46:28Z

Currently running using mysql 5.7, after #29409 is merged it will run agains mysql 5.5.

DeepDiver1975 · 2017-11-02T10:18:37Z

codecov shows that mysql code paths are touched - nice - https://codecov.io/gh/owncloud/core/pull/29410/changes

Adding --group DB would give us some speed up here as well ...

SergioBertolinSG · 2017-11-02T11:09:29Z

Adding --group DB would give us some speed up here as well ...

I've added it in the last commit, is that ok?

DeepDiver1975 · 2017-11-02T11:15:05Z

tests/drone/test-coverage.sh

+if [[ "${DB_TYPE}" == "none" ]]; then
+  GROUP="--exclude-group DB"
+else
+  GROUP="--group DB"


now sqlite is executed with --group DB as well - DB_TYPE none is missing

SergioBertolinSG · 2017-11-02T12:07:40Z

Some failures in drone after last commit:

1) Test\Encryption\EncryptionWrapperTest::testWrapStorage with data set #0 (true, array())

Your test case is not allowed to access the database.


/drone/src/tests/lib/TestCase.php:110
/drone/src/lib/composer/pimple/pimple/src/Pimple/Container.php:113
/drone/src/lib/private/AppFramework/Utility/SimpleContainer.php:111
/drone/src/lib/private/ServerContainer.php:87
/drone/src/lib/private/Server.php:1141
/drone/src/lib/private/AllConfig.php:90
/drone/src/lib/private/AllConfig.php:340
/drone/src/lib/private/AllConfig.php:251
/drone/src/lib/private/legacy/util.php:233
/drone/src/lib/private/Files/Filesystem.php:265
/drone/src/lib/private/Encryption/EncryptionWrapper.php:89
/drone/src/tests/lib/Encryption/EncryptionWrapperTest.php:75

2) Test\Files\External\PersonalMountTest::testFindByStorageId

Your test case is not allowed to access the database.

/drone/src/tests/lib/TestCase.php:110
/drone/src/lib/composer/pimple/pimple/src/Pimple/Container.php:113
/drone/src/lib/private/AppFramework/Utility/SimpleContainer.php:111
/drone/src/lib/private/ServerContainer.php:87
/drone/src/lib/private/Server.php:1141
/drone/src/lib/private/AllConfig.php:90
/drone/src/lib/private/AllConfig.php:340
/drone/src/lib/private/AllConfig.php:251
/drone/src/lib/private/legacy/util.php:233
/drone/src/lib/private/Files/Mount/Manager.php:124
/drone/src/tests/lib/Files/External/PersonalMountTest.php:47

3) Test\Files\Mount\ManagerTest::testFind

Your test case is not allowed to access the database.

/drone/src/tests/lib/TestCase.php:110
/drone/src/lib/composer/pimple/pimple/src/Pimple/Container.php:113
/drone/src/lib/private/AppFramework/Utility/SimpleContainer.php:111
/drone/src/lib/private/ServerContainer.php:87
/drone/src/lib/private/Server.php:1141
/drone/src/lib/private/AllConfig.php:90
/drone/src/lib/private/AllConfig.php:340
/drone/src/lib/private/AllConfig.php:251
/drone/src/lib/private/legacy/util.php:233
/drone/src/lib/private/Files/Mount/Manager.php:72
/drone/src/tests/lib/Files/Mount/ManagerTest.php:31

4) Test\Files\Mount\ManagerTest::testLong

Your test case is not allowed to access the database.

/drone/src/tests/lib/TestCase.php:110
/drone/src/lib/composer/pimple/pimple/src/Pimple/Container.php:113
/drone/src/lib/private/AppFramework/Utility/SimpleContainer.php:111
/drone/src/lib/private/ServerContainer.php:87
/drone/src/lib/private/Server.php:1141
/drone/src/lib/private/AllConfig.php:90
/drone/src/lib/private/AllConfig.php:340
/drone/src/lib/private/AllConfig.php:251
/drone/src/lib/private/legacy/util.php:233
/drone/src/lib/private/Files/Mount/Manager.php:124
/drone/src/tests/lib/Files/Mount/ManagerTest.php:64

DeepDiver1975 · 2017-11-02T12:15:56Z

Some failures in drone after last commit:

I'd say there are some annotations missing then

SergioBertolinSG · 2017-11-02T12:38:46Z

Should I add

* @group DB

to all those tests?

SergioBertolinSG · 2017-11-03T11:52:52Z

@DeepDiver1975 Can this be merged?

DeepDiver1975 · 2017-11-03T14:43:01Z

@DeepDiver1975 Can this be merged?

no - the code coverage report is 💩 - the expectation is that the coverage increases when adding mysql - not to decrease

SergioBertolinSG · 2017-11-06T08:08:06Z

Adding this commit f9500dc Reduced the coverage by 20,99%

Adding this one 849fcf7 incremented it 18,45%

Should it really appear incremented?

DeepDiver1975 · 2017-11-07T09:17:39Z

.drone.yml

one step should be enough - the plugin can take multiple files

or even with wild cards

SergioBertolinSG · 2017-11-08T08:02:47Z

Hmm flags appear in the report, but the github check doesn't split them

Do we need a different approach here? Making steps more explicit separating databases like in 794e529 ?

SergioBertolinSG · 2017-11-08T11:38:50Z

Removed annotations in unit tests.

DeepDiver1975 · 2017-11-08T17:05:54Z

@SergioBertolinSG please enable debug - https://github.com/robertstettner/drone-codecov#configuration
maybe we get some insights on how the plugin is uploading the reports

codecov · 2017-11-08T17:24:55Z

Codecov Report

Merging #29410 into master will decrease coverage by 1.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #29410      +/-   ##
============================================
- Coverage     61.39%    59.8%   -1.59%     
- Complexity    17472    17477       +5     
============================================
  Files          1044     1044              
  Lines         57695    59249    +1554     
============================================
+ Hits          35419    35432      +13     
- Misses        22276    23817    +1541

Flag	Coverage Δ	Complexity Δ
#unit_tests	`59.8% <ø> (?)`	`17477 <ø> (?)`

Impacted Files	Coverage Δ	Complexity Δ
settings/templates/panels/admin/apps.php	`6% <0%> (-94%)`	`0% <0%> (ø)`
lib/private/App/CodeChecker/DeprecationCheck.php	`9.52% <0%> (-90.48%)`	`5% <0%> (ø)`
settings/templates/panels/admin/filesharing.php	`10.25% <0%> (-89.75%)`	`0% <0%> (ø)`
settings/templates/panels/personal/tokens.php	`13.88% <0%> (-86.12%)`	`0% <0%> (ø)`
.../federatedfilesharing/templates/settings-admin.php	`21.42% <0%> (-78.58%)`	`0% <0%> (ø)`
...deratedfilesharing/templates/settings-personal.php	`23.25% <0%> (-76.75%)`	`0% <0%> (ø)`
core/templates/404.php	`25% <0%> (-75%)`	`0% <0%> (ø)`
settings/templates/panels/admin/tips.php	`25% <0%> (-75%)`	`0% <0%> (ø)`
core/templates/403.php	`25% <0%> (-75%)`	`0% <0%> (ø)`
settings/templates/panels/admin/certificates.php	`26.08% <0%> (-73.92%)`	`0% <0%> (ø)`
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dba2ed...2347ac8. Read the comment docs.

DeepDiver1975 · 2017-11-08T21:33:53Z

Codecov upload has issues afaik. See the logs. Master Branch is used.

SergioBertolinSG · 2017-11-09T08:58:25Z

Yes, adding it here for reference:

==> Uploading reports
    url: https://codecov.io
query: branch=master&commit=1f658a6c9808a5817cea716aacd9b36614be2e12&build=1064&build_url=&name=&tag=&slug=owncloud%2Fcore&yaml=.codecov.yml&service=&flags=unit_tests&pr=29410&job=

Here https://github.com/robertstettner/drone-codecov/blob/master/entrypoint.sh#L44-L45

the plugin uses DRONE_BRANCH.

In drone docs it says DRONE_BRANCH | commit branch

http://docs.drone.io/environment-reference/

But there is also a variable called DRONE_COMMIT_BRANCH there. Not sure if it is the same.

DeepDiver1975 · 2017-11-09T12:09:09Z

But there is also a variable called DRONE_COMMIT_BRANCH there. Not sure if it is the same.

@tboerger is there a way to see the actual env vars? THX

SergioBertolinSG · 2017-11-09T14:22:07Z

Both DRONE_BRANCH and DRONE_COMMIT_BRANCH are the same : master.

This variable contains the current branch name:

DRONE_COMMIT_REFSPEC=drone-enabling-mysql-code-coverage:master

lock · 2019-08-01T17:02:26Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

SergioBertolinSG added 3 - To Review Drone jenkins labels Nov 2, 2017

SergioBertolinSG requested a review from DeepDiver1975 November 2, 2017 09:46

SergioBertolinSG removed the jenkins label Nov 2, 2017

DeepDiver1975 added this to the development milestone Nov 2, 2017

DeepDiver1975 requested changes Nov 2, 2017

View reviewed changes

DeepDiver1975 mentioned this pull request Nov 2, 2017

MariaDB 10.2.7+ #29100

Merged

9 tasks

SergioBertolinSG self-assigned this Nov 3, 2017

SergioBertolinSG added 2 - Developing and removed 3 - To Review labels Nov 7, 2017

DeepDiver1975 reviewed Nov 7, 2017

View reviewed changes

SergioBertolinSG force-pushed the drone-enabling-mysql-code-coverage branch from dc45fb1 to e1140dc Compare November 7, 2017 12:43

SergioBertolinSG force-pushed the drone-enabling-mysql-code-coverage branch 2 times, most recently from e5fc237 to 2badd16 Compare November 8, 2017 09:46

PVince81 modified the milestones: development, planned Nov 8, 2017

owncloud deleted a comment from codecov bot Nov 8, 2017

SergioBertolinSG force-pushed the drone-enabling-mysql-code-coverage branch from d694bef to 1ff8d93 Compare November 9, 2017 14:08

Added code coverage using mysql

2347ac8

SergioBertolinSG force-pushed the drone-enabling-mysql-code-coverage branch from 1ff8d93 to 2347ac8 Compare November 10, 2017 08:33

SergioBertolinSG mentioned this pull request Nov 10, 2017

Added code coverage using mysql (second try) #29530

Closed

PVince81 modified the milestones: planned, development Nov 22, 2017

ownclouders added the status/STALE label Dec 7, 2017

DeepDiver1975 closed this Dec 14, 2017

DeepDiver1975 deleted the drone-enabling-mysql-code-coverage branch December 14, 2017 08:15

lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019

Conversation

SergioBertolinSG commented Nov 2, 2017

Uh oh!

DeepDiver1975 commented Nov 2, 2017

Uh oh!

SergioBertolinSG commented Nov 2, 2017

Uh oh!

DeepDiver1975 Nov 2, 2017

Choose a reason for hiding this comment

Uh oh!

SergioBertolinSG commented Nov 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeepDiver1975 commented Nov 2, 2017

Uh oh!

SergioBertolinSG commented Nov 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SergioBertolinSG commented Nov 3, 2017

Uh oh!

DeepDiver1975 commented Nov 3, 2017

Uh oh!

SergioBertolinSG commented Nov 6, 2017

Uh oh!

DeepDiver1975 Nov 7, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Nov 7, 2017

Choose a reason for hiding this comment

Uh oh!

SergioBertolinSG commented Nov 8, 2017

Uh oh!

SergioBertolinSG commented Nov 8, 2017

Uh oh!

DeepDiver1975 commented Nov 8, 2017

Uh oh!

codecov bot commented Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DeepDiver1975 commented Nov 8, 2017

Uh oh!

SergioBertolinSG commented Nov 9, 2017

Uh oh!

DeepDiver1975 commented Nov 9, 2017

Uh oh!

SergioBertolinSG commented Nov 9, 2017

Uh oh!

lock bot commented Aug 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SergioBertolinSG commented Nov 2, 2017 •

edited

Loading

SergioBertolinSG commented Nov 2, 2017 •

edited

Loading

codecov bot commented Nov 8, 2017 •

edited

Loading