Add IDs Generator Auto Instrumentation Config#1
Closed
NathanielRN wants to merge 10 commits intoowais:otlp-env-configfrom
Closed
Add IDs Generator Auto Instrumentation Config#1NathanielRN wants to merge 10 commits intoowais:otlp-env-configfrom
NathanielRN wants to merge 10 commits intoowais:otlp-env-configfrom
Conversation
This commit extends the instrument command so it automatically configures tracing with a provider, span processor and exporter. Most of the component used can be customized with env vars or CLI arguments. Details can be found on opentelemetry-instrumentation's README package. Fixes open-telemetry#663
b0fb9fd to
897ecfe
Compare
8 tasks
f5548ca to
2482d9f
Compare
Owner
|
@NathanielRN Not sure about carrying this PR on top of another one that is already too big. Can we open this against upstream after my PR is merged. I promise a fast review :) |
2482d9f to
0331351
Compare
Author
|
Okay I'll take your promise of a fast review :) Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am really excited for this PR! We are working on a project that uses auto instrumentation and will set custom exporters just like this.
I just wanted to added a custom ids generator to the configuration because if its not done here it would be too late to set later.
How Has This Been Tested?
I added a test to ensure the IDs Generator can be set properly!