Merged
Conversation
d45d839 to
bf8e57d
Compare
Signed-off-by: Adrien Pensart <adrien.pensart@corp.ovh.com>
bf8e57d to
d500e1a
Compare
amstuta
requested changes
Feb 23, 2026
Collaborator
amstuta
left a comment
There was a problem hiding this comment.
Also, you need to run make doc to add the doc pages
Comment on lines
+30
to
+34
| SSHKeyCreationParameters = struct { | ||
| Name string `json:"name,omitempty"` | ||
| PublicKey string `json:"publicKey,omitempty"` | ||
| Region string `json:"region,omitzero"` | ||
| }{} |
Collaborator
There was a problem hiding this comment.
Suggested change
| SSHKeyCreationParameters = struct { | |
| Name string `json:"name,omitempty"` | |
| PublicKey string `json:"publicKey,omitempty"` | |
| Region string `json:"region,omitzero"` | |
| }{} | |
| SSHKeyCreationParameters struct { | |
| Name string `json:"name,omitempty"` | |
| PublicKey string `json:"publicKey,omitempty"` | |
| Region string `json:"region,omitzero"` | |
| } |
Collaborator
There was a problem hiding this comment.
also, why omitzero on the Region ? For consistency I'd rather have either omitempty or omitzero on all fields.
| @@ -0,0 +1,4 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
This file will never be used if you don't set the following flags on the command: https://github.com/ovh/ovhcloud-cli/blob/main/internal/cmd/account.go#L81-L84
1 task
Signed-off-by: Adrien Pensart <adrien.pensart@corp.ovh.com>
amstuta
reviewed
Feb 23, 2026
|
|
||
| // sshKeyCreationParameters holds the parameters for creating a new SSH key. | ||
| SSHKeyCreationParameters struct { | ||
| Name string `json:"name"` |
Collaborator
There was a problem hiding this comment.
both should also have the omitempty tag so that common.CreateResource works correctly
Signed-off-by: Adrien Pensart <adrien.pensart@corp.ovh.com>
amstuta
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue if applicable.
Fixes #xx (issue)
Type of change
Please delete options that are not relevant.
Checklist:
make docgo mod tidy