Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces comprehensive support for managing OVHcloud Savings Plans through the CLI, enabling users to subscribe to, manage, and monitor cost-saving commitments for their cloud resources.
Changes:
- Adds a complete
cloud savings-plancommand suite with subcommands for listing, subscribing, simulating, terminating, and modifying savings plans - Implements intelligent offer lookup based on flavor and deployment type (1AZ/3AZ) with automatic filtering
- Includes comprehensive test coverage for all savings plan operations with mocked API responses
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/services/cloud/cloud_savings_plan.go | Core implementation of savings plan operations including subscription, termination, and modification logic |
| internal/services/cloud/templates/cloud_savings_plan.tmpl | Display template for rendering savings plan details in markdown format |
| internal/cmd/cloud_savings_plan.go | Command structure and CLI interface for all savings plan commands |
| internal/cmd/cloud_savings_plan_test.go | Comprehensive test suite covering all savings plan operations |
| internal/cmd/cmd_test.go | Test infrastructure updates to capture stdout for better test debugging |
| internal/cmd/cloud_project.go | Integration point registering savings plan commands with cloud command group |
| doc/*.md | Auto-generated documentation for all savings plan commands and options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9cec446 to
e5de27a
Compare
maxatome
reviewed
Feb 3, 2026
Signed-off-by: Arthur Amstutz <arthur.amstutz@gmail.com> Signed-off-by: Arthur Amstutz <arthur.amstutz@corp.ovh.com>
e5de27a to
443a2b4
Compare
maxatome
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
cloud savings-plancommands.Fixes #116 (issue)
Type of change
Checklist:
make docgo mod tidy