Add domain-zone record create and delete, commands by TheoBrigitte · Pull Request #108 · ovh/ovhcloud-cli

TheoBrigitte · 2025-11-29T00:09:58Z

Fixes #104

Description

This PR introduces 2 new domain-zone record sub-commands to create and delete DNS records.

The create command is similar to the update one which allow to use a file or the editor with a pre-filled schema. I've listed the records type in the --fieldType help text. Also I was unsure if I should use camel case or not for this flag. Most help texts have been taken straight out of the API documentation.
The delete command is fairly straightforward and just issue an HTTP Delete with to the right endpoint.

Tests have been added, along with docs.

Type of changea

New feature (non-breaking change which adds functionality)
Documentation update

Checklist:

My code follows the style guidelines of this project
I have commented my code
I updated the documentation by running make doc
I ran go mod tidy
I have added tests that prove my fix is effective or that my feature works

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

amstuta

Thanks for your contribution @TheoBrigitte !

Just added a few comments but almost good to merge :)

internal/cmd/domainzone.go

internal/cmd/domainzone_test.go

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

doc/ovhcloud_domain-zone_record_create.md

amstuta · 2025-12-01T10:15:55Z

internal/cmd/domainzone_test.go

+		}`),
+	)
+
+	out, err := cmd.Execute("domain-zone", "record", "create", "example.com", "--fieldType", "A", "--subdomain", "example-created", "--target", "127.0.0.1", "--ttl", "0")


Suggested change

out, err := cmd.Execute("domain-zone", "record", "create", "example.com", "--fieldType", "A", "--subdomain", "example-created", "--target", "127.0.0.1", "--ttl", "0")

out, err := cmd.Execute("domain-zone", "record", "create", "example.com", "--field-type", "A", "--sub-domain", "example-created", "--target", "127.0.0.1", "--ttl", "0")

The subdomain flag will then become inconsistent with the one used in the update record command.

oups my bad I missed this, in this case you're right we should keep subdomain everywhere

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

internal/cmd/domainzone.go

TheoBrigitte · 2025-12-05T21:18:25Z

My bad I had not pushed my changes. It should be alright now.

amstuta

Just a small change of URLs to use (prefix /v1 to add) and we're good to merge ;)

internal/services/domainzone/domainzone.go

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

TheoBrigitte · 2025-12-09T20:40:04Z

Alright, should be good now :)

amstuta · 2025-12-11T07:32:41Z

@TheoBrigitte you have some tests failing due to the URL change (I think). Could you fix them, and then we'll be able to merge ? :)

…eate

TheoBrigitte · 2025-12-11T09:18:50Z

That's fixed :)

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

DavidGOrtega · 2026-02-28T12:34:02Z

These commands do not appear in the CLI!!!??? My version is 0.9.0 @TheoBrigitte @amstuta

ovhcloud domain-zone record --help
Retrieve information and manage your DNS records within a zone

Usage:
  ovhcloud domain-zone record [command]

Available Commands:
  get         Get a single DNS record from your zone
  update      Update a single DNS record from your zone

Flags:
  -h, --help   help for record

Global Flags:
  -d, --debug           Activate debug mode (will log all HTTP requests details)
  -f, --format string   Output value according to given format (expression using https://github.com/PaesslerAG/gval syntax)
                        Examples:
                          --format 'id' (to extract a single field)
                          --format 'nested.field.subfield' (to extract a nested field)
                          --format '[id, 'name']' (to extract multiple fields as an array)
                          --format '{"newKey": oldKey, "otherKey": nested.field}' (to extract and rename fields in an object)
                          --format 'name+","+type' (to extract and concatenate fields in a string)
                          --format '(nbFieldA + nbFieldB) * 10' (to compute values from numeric fields)
  -e, --ignore-errors   Ignore errors in API calls when it is not fatal to the execution
  -i, --interactive     Interactive output
  -j, --json            Output in JSON
  -y, --yaml            Output in YAML

Use "ovhcloud domain-zone record [command] --help" for more information about a command.

TheoBrigitte requested a review from a team as a code owner November 29, 2025 00:09

TheoBrigitte added 6 commits November 29, 2025 01:10

Add domain-zone record create, command

58c8f79

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

regenerate doc: make doc

2dab7c5

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

Add test TestDomainZoneCreateRecord

6ccfcab

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

Add domain-zone record delete, command

b004e59

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

regenerate doc: make doc

8547ec4

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

Add test TestDomainZoneDeleteRecord

f6620db

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

TheoBrigitte force-pushed the domain-zone-record-create branch from 8eb469e to f6620db Compare November 29, 2025 00:11

TheoBrigitte mentioned this pull request Nov 29, 2025

[Feature]: subcommand to create a DNS record #104

Closed

1 task

amstuta reviewed Dec 1, 2025

View reviewed changes

internal/cmd/domainzone.go Outdated Show resolved Hide resolved

internal/cmd/domainzone.go Outdated Show resolved Hide resolved

internal/cmd/domainzone.go Outdated Show resolved Hide resolved

internal/cmd/domainzone_test.go Outdated Show resolved Hide resolved

TheoBrigitte and others added 4 commits December 1, 2025 10:33

Update internal/cmd/domainzone.go

4218cc6

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Update internal/cmd/domainzone.go

abe767f

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Update internal/cmd/domainzone.go

89b4b43

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Fix identation in internal/cmd/domainzone_test.go

7caa15f

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

TheoBrigitte force-pushed the domain-zone-record-create branch from 608f47c to 7caa15f Compare December 1, 2025 09:37

amstuta reviewed Dec 1, 2025

View reviewed changes

doc/ovhcloud_domain-zone_record_create.md Outdated Show resolved Hide resolved

amstuta reviewed Dec 1, 2025

View reviewed changes

TheoBrigitte added 3 commits December 1, 2025 11:58

run make doc

09c59e4

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

Use --sub-domain in domain record update command

16a5ffd

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

Update tests

059d077

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

amstuta reviewed Dec 1, 2025

View reviewed changes

internal/cmd/domainzone.go Show resolved Hide resolved

amstuta requested changes Dec 9, 2025

View reviewed changes

internal/services/domainzone/domainzone.go Outdated Show resolved Hide resolved

internal/services/domainzone/domainzone.go Outdated Show resolved Hide resolved

TheoBrigitte and others added 2 commits December 9, 2025 21:35

Update internal/services/domainzone/domainzone.go

0eb89e9

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Update internal/services/domainzone/domainzone.go

29b652f

Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com> Signed-off-by: Théo Brigitte <theo.brigitte@gmail.com>

Merge remote-tracking branch 'origin/main' into domain-zone-record-cr…

db49e2a

…eate

Fix tests

275b014

Signed-off-by: Theo Brigitte <theo.brigitte@gmail.com>

TheoBrigitte force-pushed the domain-zone-record-create branch from c5a1e57 to 275b014 Compare December 11, 2025 09:23

amstuta merged commit 08eb50e into ovh:main Dec 11, 2025
3 checks passed

DavidGOrtega mentioned this pull request Feb 28, 2026

New releases periocity #157

Closed

	out, err := cmd.Execute("domain-zone", "record", "create", "example.com", "--fieldType", "A", "--subdomain", "example-created", "--target", "127.0.0.1", "--ttl", "0")
	out, err := cmd.Execute("domain-zone", "record", "create", "example.com", "--field-type", "A", "--sub-domain", "example-created", "--target", "127.0.0.1", "--ttl", "0")

Conversation

TheoBrigitte commented Nov 29, 2025

Description

Type of changea

Checklist:

Uh oh!

amstuta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amstuta Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

TheoBrigitte Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

amstuta Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheoBrigitte commented Dec 5, 2025

Uh oh!

amstuta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheoBrigitte commented Dec 9, 2025

Uh oh!

amstuta commented Dec 11, 2025

Uh oh!

TheoBrigitte commented Dec 11, 2025

Uh oh!

Uh oh!

DavidGOrtega commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants