Skip to content

Add attachFloatinIps spec on nodepool#107

Merged
amstuta merged 6 commits intoovh:mainfrom
atnbrg:feat/cloud-kube-nodepool-floatingIps
Dec 15, 2025
Merged

Add attachFloatinIps spec on nodepool#107
amstuta merged 6 commits intoovh:mainfrom
atnbrg:feat/cloud-kube-nodepool-floatingIps

Conversation

@atnbrg
Copy link
Contributor

@atnbrg atnbrg commented Nov 28, 2025 •
edited
Loading

Description

Please include a summary of the changes and the related issue if applicable.

Fixes #xx (issue)

Type of change

Please delete options that are not relevant.

  • Improvement (improvement of existing commands)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code
  • I updated the documentation by running make doc

@atnbrg atnbrg force-pushed the feat/cloud-kube-nodepool-floatingIps branch 5 times, most recently from 66d3de9 to 16e34c1 Compare December 5, 2025 08:27
@atnbrg atnbrg marked this pull request as ready for review December 5, 2025 08:28
@atnbrg atnbrg requested a review from a team as a code owner December 5, 2025 08:28
@atnbrg atnbrg changed the title feat : add attachFloatinIps Add attachFloatinIps on nodepool Dec 5, 2025
@atnbrg atnbrg changed the title Add attachFloatinIps on nodepool Add attachFloatinIps spec on nodepool Dec 5, 2025
@atnbrg atnbrg force-pushed the feat/cloud-kube-nodepool-floatingIps branch 4 times, most recently from 3185e7c to 51fe77e Compare December 8, 2025 09:42
amstuta
amstuta requested changes Dec 9, 2025
View reviewed changes
@atnbrg atnbrg force-pushed the feat/cloud-kube-nodepool-floatingIps branch 2 times, most recently from a4e2c8d to cc66781 Compare December 9, 2025 18:43
@atnbrg atnbrg requested a review from amstuta December 9, 2025 18:45
@atnbrg
feat : add attachFloatinIps
87d7486 
Signed-off-by: Anthony Berger <anthony.berger@ovhcloud.com>
@atnbrg atnbrg force-pushed the feat/cloud-kube-nodepool-floatingIps branch from a798058 to 87d7486 Compare December 10, 2025 08:49
amstuta
amstuta reviewed Dec 11, 2025
View reviewed changes
atnbrg and others added 5 commits December 11, 2025 20:50
@atnbrg @amstuta
Update internal/cmd/cloud_kube_nodepool_test.go
c498ce5 
Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com>
Signed-off-by: anthony berger <156782069+atnbrg@users.noreply.github.com>
@atnbrg @amstuta
Update internal/cmd/cloud_kube_nodepool_test.go
9c38f8a 
Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com>
Signed-off-by: anthony berger <156782069+atnbrg@users.noreply.github.com>
@atnbrg @amstuta
Update internal/cmd/cloud_kube_nodepool_test.go
77d18d9 
Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com>
Signed-off-by: anthony berger <156782069+atnbrg@users.noreply.github.com>
@atnbrg @amstuta
Update internal/cmd/cloud_kube_nodepool_test.go
94ec53d 
Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com>
Signed-off-by: anthony berger <156782069+atnbrg@users.noreply.github.com>
@atnbrg @amstuta
Update internal/cmd/cloud_kube_nodepool_test.go
bf4e829 
Co-authored-by: Arthur Amstutz <18141571+amstuta@users.noreply.github.com>
Signed-off-by: anthony berger <156782069+atnbrg@users.noreply.github.com>
@atnbrg atnbrg requested a review from amstuta December 11, 2025 19:52
@amstuta amstuta merged commit f71e5d4 into ovh:main Dec 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amstuta amstuta amstuta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atnbrg @amstuta