chore: disable interacting with doors if ped is in any vehicle#156
Merged
Conversation
thelindat
reviewed
Jun 27, 2024
| ---@return boolean? | ||
| local function canInteractWithDoor(entity, coords, door, useOffset) | ||
| if not GetIsDoorValid(entity, door) or GetVehicleDoorLockStatus(entity) > 1 or IsVehicleDoorDamaged(entity, door) then return end | ||
| if not GetIsDoorValid(entity, door) or GetVehicleDoorLockStatus(entity) > 1 or IsVehicleDoorDamaged(entity, door) or IsPedInAnyVehicle(PlayerPedId(), false) then return end |
Member
There was a problem hiding this comment.
just cache.vehicle will suffice
Contributor
Author
There was a problem hiding this comment.
Modified the code so it uses cache.vehicle, thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
we'r about to use ox_target on our Server and i'd like to use those defaults for simple vehicle interactions. We just found out, that you can interact with other vehicles even if your driving/sitting in yet another vehicle. I think this is not the desired behaviour and therefore should be changed.
If this change will not be merged, its fine by us, we will probably just copy the implementation, deactive the defaults and add those restriction on our own. But we think, everyone using the default should profit from this change, as it improves the immersivity.☺️
Have a greate day,
SeaLife