fix(setStored): remove vin from OxVehicle list#246
Merged
Conversation
Ehbw
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this.despawn does not trigger
OxVehicle.remove(this.vin)and if we delete an entity without removing it from OxVehicle it tries to respawn it using the old entity and it breaks.This just changes this,despawn to this.remove which does the same but also calls
OxVehicle.remove(this.vin)not sure if it should of been just called directly in despawn, not sure as I couldnt see any use cases for that but I just went the "safe route"