Merged
Conversation
Loosely based on evanw/esbuild#1385
dylan-conway
approved these changes
Jun 4, 2024
Member
dylan-conway
left a comment
There was a problem hiding this comment.
Nice, code and tests look good
Member
|
Looks like expected test failures from output change |
Contributor
|
❌ @Jarred-Sumner, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
💻 1 failing tests Darwin x64 baseline
💻 1 failing tests Darwin x64
🐧💪 1 failing tests Linux AARCH64
🐧🖥 1 failing tests Linux x64 baseline
🐧🖥 1 failing tests Linux x64
🪟💻 7 failing tests Windows x64 baseline
🪟💻 6 failing tests Windows x64
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes Bun print
Infinityas1 / 0when either (1) we are not renaming symbols, like at runtime or (2) when bundling with --minify-syntax.Fixes #7263
Loosely based on evanw/esbuild#1385
Since this is an observable output change, this bumps the runtime transpiler cache version.
How did you verify your code works?
There are some tests