chore!: handle conflict phpunit 12+ conflict preload with rector#44
Open
samsonasik wants to merge 3 commits intoostrolucky:mainfrom
Open
chore!: handle conflict phpunit 12+ conflict preload with rector#44samsonasik wants to merge 3 commits intoostrolucky:mainfrom
samsonasik wants to merge 3 commits intoostrolucky:mainfrom
Conversation
This was referenced Jul 2, 2025
Owner
|
Thank you! However, it seems this breaks phpstan now? 🤔 |
Author
|
@ostrolucky in seems in if (defined('__PHPSTAN_RUNNING__')) {
return;
}I will create PR for that. |
|
(Got a similar problem.. thank you @samsonasik for your messages on rector, here, and for sharing the solutions!) |
samsonasik
commented
Jul 23, 2025
| "require": { | ||
| "php": "^8.1", | ||
| "rector/rector": "^1.0 || ^2.1" | ||
| "rector/rector": "dev-main#3c07e2ab69c55752e5f143ea99119b475e14ac19" |
Author
There was a problem hiding this comment.
@ostrolucky I temporary use rector/rector:dev-main so it can be checked that it works on this PR
Author
There was a problem hiding this comment.
@ostrolucky feel free to take care the rest when next rector released :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@ostrolucky here to handle preload conflict in issue:
Motivation and context
To make work on php 8.3
How has this been tested?
Yes, run composer update && vendor/bin/phpunit on php8.3 env
Types of changes
PR checklist