aboot: Use fd and not absolute path#3507
Merged
jmarrero merged 1 commit intoostreedev:mainfrom Aug 21, 2025
Merged
Conversation
Motivated by bootc-dev/bootc@6d2eb2a (We need to have a shared helper for this stuff at some point)
There was a problem hiding this comment.
Code Review
This pull request refactors the aboot bootloader support to use a file descriptor with fchdir instead of an absolute path when calling aboot-deploy. This is a good improvement for robustness, avoiding potential TOCTOU race conditions. The implementation is sound. I've added a couple of minor suggestions to use GLib's idiomatic macros for converting between integers and pointers, which will improve code readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by bootc-dev/bootc@6d2eb2a
(We need to have a shared helper for this stuff at some point)