HLS: Add missing newline to end of session manifest. v6.0.143#4115
Merged
winlinvip merged 3 commits intoossrs:developfrom Jul 24, 2024
Merged
HLS: Add missing newline to end of session manifest. v6.0.143#4115winlinvip merged 3 commits intoossrs:developfrom
winlinvip merged 3 commits intoossrs:developfrom
Conversation
32eb3e3 to
e782b8e
Compare
e782b8e to
798c969
Compare
Member
|
Thank you for this PR! Is there any specification about the newline? As you know, some player might also reject it when got empty line. |
Contributor
Author
|
Well, there is the common POSIX rule that a text file should contain lines which should end with a terminating newline (some tools will ignore the final line if it is not terminated) and there is the RFC stating HLS files are UTF-8 text files: We do have embedded players which cannot play it without the newline and I have not come across any player yet that cannot play it when the newline is added, but that obviously isn't any proper proof. Edit: Oh, actually the RFC mentions this in itself already: |
Member
|
Make sense, thank you. |
winlinvip
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session HLS manifest file lacks a terminating newline in the final line.
This may cause strict players to reject it.