Fix security scan problems. v6.0.131#4100
Merged
winlinvip merged 3 commits intoossrs:developfrom Jun 21, 2024
Merged
Conversation
Contributor
suzp1984
commented
Jun 21, 2024
- fix redundant null check, there is no potential risks by the way, just redundant null check.
- Potential use pointer after free, that's not true. So we can ignore this one, or find a way to make stupid security tool happy.
ph is a pointer to pointer, which is used to pass a pointer, entry->stream, out of the method, and ph already dereferenced on the begining of this method, so it's impossible to be null. `ISrsHttpHander* h = *ph ? *ph : NULL`
security scan said use pointer after free, actually it's not true, it's totally safe here, so free pointer in another name, check the stupid security tool's response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.