Player: Fix empty img tag occupy 20px size in safari. v6.0.142#4029
Merged
winlinvip merged 3 commits intoossrs:developfrom Jul 24, 2024
Merged
Player: Fix empty img tag occupy 20px size in safari. v6.0.142#4029winlinvip merged 3 commits intoossrs:developfrom
winlinvip merged 3 commits intoossrs:developfrom
Conversation
Contributor
Author
|
I guess the e.g. srs/trunk/research/console/ng_index.html Line 23 in 427104f srs/trunk/research/players/whep.html Line 19 in 427104f srs/trunk/research/players/whip.html Line 19 in 427104f |
winlinvip
reviewed
Jul 8, 2024
35f8a04 to
ca29cd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the html img tag occupy 20px size in safari.
srs/trunk/research/players/rtc_player.html
Line 19 in 427104f
(ignore the img css warning:
auto\9;it's another problem, I will file another PR.)but, the empty img tag just occupy 1px size in chrome. So I guess it's a html compatible problem.
TRANS_BY_GPT4