Skip to content

Debug: reuse endpoint with RTC and server error.#4024

Closed
suzp1984 wants to merge 1 commit intoossrs:developfrom
suzp1984:debug/ssl-connection-reuse-rtc-with-server
Closed

Debug: reuse endpoint with RTC and server error.#4024
suzp1984 wants to merge 1 commit intoossrs:developfrom
suzp1984:debug/ssl-connection-reuse-rtc-with-server

Conversation

@suzp1984
Copy link
Copy Markdown
Contributor

@suzp1984 suzp1984 commented Apr 14, 2024 •
edited
Loading

srs/trunk/src/app/srs_app_server.cpp

Lines 1197 to 1201 in 427104f

resource = new SrsRtcTcpConn(io, ip, port, this);
} else {
resource = new SrsHttpxConn(listener == http_listener_, this, io, http_server, ip, port);
}
}

I believe this is a mistake, if reuse the RTC and http server listener, then Http Server connection will be created with incorrect SSL options.

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Apr 14, 2024
@suzp1984 suzp1984 mentioned this pull request Apr 14, 2024
Closed
@suzp1984
Copy link
Copy Markdown
Contributor Author

suzp1984 commented Apr 17, 2024

conflict with #4028 , so close this one.

@suzp1984 suzp1984 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

EnglishNative This issue is conveyed exclusively in English.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suzp1984 @winlinvip