Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 by chundonglinlin · Pull Request #3389 · ossrs/srs

chundonglinlin · 2023-01-27T15:16:43Z

When publish stream with NVENC and LARIX by SRT or RTMP, maybe demux pps failed. Likely,

[2023-01-27 15:14:46.881][WARN][2338][81rhc7z9][22] parse ts packet err=code=4054(CasterTsHevcVps)(Invalid ts HEVC VPS for stream caster) : ts: handle ts message : ts: consume hevc video : check vps sps pps : srt to rtmp vps/sps/pps : format consume video : demux hevc VPS/SPS/PPS : hevc demux vps/sps/pps failed : scaling_list_delta_coef : read uev : no bytes for leadingZeroBits=1
thread [2338][81rhc7z9]: decode() [./src/kernel/srs_kernel_ts.cpp:273][errno=22]
thread [2338][81rhc7z9]: on_ts_message() [./src/app/srs_app_srt_source.cpp:364][errno=22]
thread [2338][81rhc7z9]: on_ts_video_hevc() [./src/app/srs_app_srt_source.cpp:607][errno=22]
thread [2338][81rhc7z9]: check_vps_sps_pps_change() [./src/app/srs_app_srt_source.cpp:654][errno=22]
thread [2338][81rhc7z9]: on_video_imp() [./src/app/srs_app_source.cpp:2437][errno=22]
thread [2338][81rhc7z9]: video_avc_demux() [./src/kernel/srs_kernel_codec.cpp:896][errno=22]
thread [2338][81rhc7z9]: hevc_demux_hvcc() [./src/kernel/srs_kernel_codec.cpp:1050][errno=22]
thread [2338][81rhc7z9]: hevc_demux_pps_rbsp() [./src/kernel/srs_kernel_codec.cpp:1698][errno=22]
thread [2338][81rhc7z9]: read_bits_se() [./src/kernel/srs_kernel_buffer.cpp:511][errno=22]
thread [2338][81rhc7z9]: read_bits_ue() [./src/kernel/srs_kernel_buffer.cpp:489][errno=22]
[2023-01-27 15:14:46.881][WARN][2338][81rhc7z9][22] parse ts packet err=code=4019(CasterTsPse)(Invalid ts PSE payload for stream caster) : ts: ts packet decode : ts: demux payload : ts: PES fresh packet length=0, us=0, cc=5
thread [2338][81rhc7z9]: decode() [./src/kernel/srs_kernel_ts.cpp:264][errno=22]
thread [2338][81rhc7z9]: decode() [./src/kernel/srs_kernel_ts.cpp:629][errno=22]
thread [2338][81rhc7z9]: decode() [./src/kernel/srs_kernel_ts.cpp:1955][errno=22]

johan149 · 2023-01-27T15:56:13Z

it's not working yet. When I stream using NVENC, I get this:

[2023-01-27 15:53:26.736][INFO][1][379m06q7] TCP: clear zombies=1 resources, conns=2, removing=0, unsubs=0
[2023-01-27 15:53:26.736][INFO][1][028s0412] TCP: disposing #0 resource(HttpConn)(0x7ff4dc0aae30), conns=2, disposing=1, zombies=0
[2023-01-27 15:53:27.523][ERROR][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/common.cpp:305(pton) # : pton: IPE or net error: can't determine IPv4 carryover format: 6400:9bff:0:0:0:0:7432:532c(Resource temporarily unavailable)
[2023-01-27 15:53:27.523][WARN][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/core.cpp:2156(processSrtMsg_HSREQ) # : HSREQ/rcv: Agent did not set rcv-TSBPD - ignoring proposed latency from peer
[2023-01-27 15:53:27.523][ERROR][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/common.cpp:305(pton) # : pton: IPE or net error: can't determine IPv4 carryover format: 6400:9bff:0:0:0:0:7432:532c(Resource temporarily unavailable)
[2023-01-27 15:53:27.531][ERROR][1][6a823h29][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/api.cpp:1116(accept) # : srt_accept: no pending connection available at the moment(Resource temporarily unavailable)

and when I tried to play the .ts stream, I get this

[2023-01-27 15:53:44.491][INFO][1][bi42mu17] TCP: before dispose resource(HttpConn)(0x7ff4dc2aa750), conns=2, zombies=0, ign=0, inz=0, ind=0
[2023-01-27 15:53:44.491][ERROR][1][bi42mu17][0] serve error code=4054(CasterTsHevcVps)(Invalid ts HEVC VPS for stream caster) : process request=0 : mux serve : serve http : send messages : send messages : write video : ts: on video : demux hevc VPS/SPS/PPS : hevc demux vps/sps/pps failed : log2_sao_offset_scale_luma : no bytes for leadingZeroBits=1
thread [1][bi42mu17]: process_requests() [./src/app/srs_app_http_conn.cpp:206][errno=0]
thread [1][bi42mu17]: process_request() [./src/app/srs_app_http_conn.cpp:233][errno=0]
thread [1][bi42mu17]: serve_http() [./src/protocol/srs_protocol_http_stack.cpp:765][errno=0]
thread [1][bi42mu17]: do_serve_http() [./src/app/srs_app_http_stream.cpp:758][errno=0]
thread [1][bi42mu17]: streaming_send_messages() [./src/app/srs_app_http_stream.cpp:858][errno=0]
thread [1][bi42mu17]: write_video() [./src/app/srs_app_http_stream.cpp:214][errno=0]
thread [1][bi42mu17]: write_video() [./src/kernel/srs_kernel_ts.cpp:3273][errno=0]
thread [1][bi42mu17]: video_avc_demux() [./src/kernel/srs_kernel_codec.cpp:896][errno=0]
thread [1][bi42mu17]: hevc_demux_hvcc() [./src/kernel/srs_kernel_codec.cpp:1050][errno=0]
thread [1][bi42mu17]: hevc_demux_pps_rbsp() [./src/kernel/srs_kernel_codec.cpp:1788][errno=0]
thread [1][bi42mu17]: read_bits_ue() [./src/kernel/srs_kernel_buffer.cpp:489][errno=0]
[2023-01-27 15:53:44.491][INFO][1][379m06q7] TCP: clear zombies=1 resources, conns=2, removing=0, unsubs=0

chundonglinlin · 2023-01-27T16:26:24Z

it's not working yet. When I stream using NVENC, I get this:

[2023-01-27 15:53:26.736][INFO][1][379m06q7] TCP: clear zombies=1 resources, conns=2, removing=0, unsubs=0
[2023-01-27 15:53:26.736][INFO][1][028s0412] TCP: disposing #0 resource(HttpConn)(0x7ff4dc0aae30), conns=2, disposing=1, zombies=0
[2023-01-27 15:53:27.523][ERROR][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/common.cpp:305(pton) # : pton: IPE or net error: can't determine IPv4 carryover format: 6400:9bff:0:0:0:0:7432:532c(Resource temporarily unavailable)
[2023-01-27 15:53:27.523][WARN][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/core.cpp:2156(processSrtMsg_HSREQ) # : HSREQ/rcv: Agent did not set rcv-TSBPD - ignoring proposed latency from peer
[2023-01-27 15:53:27.523][ERROR][1][][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/common.cpp:305(pton) # : pton: IPE or net error: can't determine IPv4 carryover format: 6400:9bff:0:0:0:0:7432:532c(Resource temporarily unavailable)
[2023-01-27 15:53:27.531][ERROR][1][6a823h29][11][SRT] /srs/objs/Platform-SRS6-Linux-5.4.0-GCC4.8.5-x86_64/srt-1-fit/srtcore/api.cpp:1116(accept) # : srt_accept: no pending connection available at the moment(Resource temporarily unavailable)

and when I tried to play the .ts stream, I get this

[2023-01-27 15:53:44.491][INFO][1][bi42mu17] TCP: before dispose resource(HttpConn)(0x7ff4dc2aa750), conns=2, zombies=0, ign=0, inz=0, ind=0
[2023-01-27 15:53:44.491][ERROR][1][bi42mu17][0] serve error code=4054(CasterTsHevcVps)(Invalid ts HEVC VPS for stream caster) : process request=0 : mux serve : serve http : send messages : send messages : write video : ts: on video : demux hevc VPS/SPS/PPS : hevc demux vps/sps/pps failed : log2_sao_offset_scale_luma : no bytes for leadingZeroBits=1
thread [1][bi42mu17]: process_requests() [./src/app/srs_app_http_conn.cpp:206][errno=0]
thread [1][bi42mu17]: process_request() [./src/app/srs_app_http_conn.cpp:233][errno=0]
thread [1][bi42mu17]: serve_http() [./src/protocol/srs_protocol_http_stack.cpp:765][errno=0]
thread [1][bi42mu17]: do_serve_http() [./src/app/srs_app_http_stream.cpp:758][errno=0]
thread [1][bi42mu17]: streaming_send_messages() [./src/app/srs_app_http_stream.cpp:858][errno=0]
thread [1][bi42mu17]: write_video() [./src/app/srs_app_http_stream.cpp:214][errno=0]
thread [1][bi42mu17]: write_video() [./src/kernel/srs_kernel_ts.cpp:3273][errno=0]
thread [1][bi42mu17]: video_avc_demux() [./src/kernel/srs_kernel_codec.cpp:896][errno=0]
thread [1][bi42mu17]: hevc_demux_hvcc() [./src/kernel/srs_kernel_codec.cpp:1050][errno=0]
thread [1][bi42mu17]: hevc_demux_pps_rbsp() [./src/kernel/srs_kernel_codec.cpp:1788][errno=0]
thread [1][bi42mu17]: read_bits_ue() [./src/kernel/srs_kernel_buffer.cpp:489][errno=0]
[2023-01-27 15:53:44.491][INFO][1][379m06q7] TCP: clear zombies=1 resources, conns=2, removing=0, unsubs=0

Do you successfully publish stream through LARIX APP? But you failed to play the .ts stream, url looks like http://127.0.0.1:8080/live/srt_hevc_nvenc.ts? @johan149

johan149 · 2023-01-27T16:40:01Z

Yes, I was able to see the stream details on the webUI of SRS it was not showing blank anymore, but when I tried to play the srt_hevc_nvenc.ts didn't work.

chundonglinlin · 2023-01-28T02:36:49Z

@johan149 Have you played other stream url, for instance,
srt_url: 'srt://127.0.0.1:10080?streamid=#!::r=live/srt_hevc_nvenc,m=request'
rtmp_url: rtmp://127.0.0.1:1935/live/srt_hevc_nvenc
http_flv_url: http://127.0.0.1:8080/live/srt_hevc_nvenc.flv
I see your SRS config again, I think you should play hls_url(http://127.0.0.1:8080/live/srt_hevc_nvenc.m3u8). If you want play http://127.0.0.1:8080/live/srt_hevc_nvenc.ts, you should add the following config,

    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }

trunk/src/kernel/srs_kernel_codec.cpp

winlinvip · 2023-01-28T02:52:42Z

@johan149 Have you played other stream url, for instance, srt_url: 'srt://127.0.0.1:10080?streamid=#!::r=live/srt_hevc_nvenc,m=request' rtmp_url: rtmp://127.0.0.1:1935/live/srt_hevc_nvenc http_flv_url: http://127.0.0.1:8080/live/srt_hevc_nvenc.flv I see your SRS config again, I think you should play hls_url(http://127.0.0.1:8080/live/srt_hevc_nvenc.m3u8). If you want play http://127.0.0.1:8080/live/srt_hevc_nvenc.ts, you should add the following config,
    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }

If enable HLS and HTTP-TS, SRS can't identify the protocol(HLS or HTTP-TS) when viewer accesses the url http://x/y/z.ts, because it might be HTTP-TS or HLS file.

So, we should detect the conflict for HLS and HTTP-TS, which should return error when enable both.

Let me file another issue for this #3391

johan149 · 2023-01-28T03:31:16Z

Oh yes, I had HLS, and TS turned ON. Let me try now with just SRT, FLV, HLS

johan149 · 2023-01-28T06:37:25Z

@chundonglinlin @winlinvip, here are the results of the test I conducted.

Publish

srt://127.0.0.1:10080?streamid=#!::r=live/srt_hevc,m=publish

WORKS---------------FFmpeg libx265
WORKS---------------FFmpeg Nvenc
DOESN'T WORK------Larix Hevc
DOESN'T WORK------OBS Nvenc

Publish

rtmp://127.0.0.1:1935/live/rtmp_hevc

WORKS--------------FFmpeg libx265
WORKS--------------FFmpeg Nvenc
DOESN'T WORK-----Larix Hevc
DOESN'T WORK-----OBS Nvenc

Play

http://127.0.0.1:8080/live/srt_hevc.flv
rtmp://127.0.0.1:1935/live/srt_hevc
http://127.0.0.1:8080/live/srt_hevc.m3u8
srt://127.0.0.1:10080?streamid=#!::r=live/srt_hevc,m=request
http://127.0.0.1:8080/live/srt_hevc.ts

WORKS--------------FLV
WORKS--------------RTMP
WORKS--------------HLS
WORKS--------------SRT
DOESN'T WORK-----TS ----when HLS and TS are enabled.

chundonglinlin · 2023-01-30T08:26:41Z

@johan149

Do you test my branch(chundonglinlin:bugfix/fix-demux-codec-pps-error) by Larix APP publishing?

Moreover, DOESN'T WORK------OBS Nvenc how via obs hevc to test?

Do you have OBS-hevc plugin for test? You can provide me for test.

johan149 · 2023-01-30T16:02:01Z

@johan149

Do you test my branch(chundonglinlin:bugfix/fix-demux-codec-pps-error) by Larix APP publishing?

Moreover, DOESN'T WORK------OBS Nvenc how via obs hevc to test?

Do you have OBS-hevc plugin for test? You can provide me for test.

Yes, I'm using your branch, and I get this error while trying to stream with Larix

and when I tried to stream with OBS-HEVC I get this error

I gave you access to a server with nvenc and obs support so we can test. check discord.

winlinvip · 2023-02-07T12:36:02Z

trunk/src/kernel/srs_kernel_codec.cpp

+    sub_layer_profile_space.clear();
+    sub_layer_tier_flag.clear();
+    sub_layer_profile_idc.clear();
+    sub_layer_profile_compatibility_flag.clear();


When released, these vectors don't need to be taken care of, right? They will be released automatically.

TRANS_BY_GPT3

winlinvip · 2023-02-07T12:36:57Z

trunk/src/kernel/srs_kernel_codec.cpp

+    sub_layer_level_idc.clear();
+}
+
+srs_error_t SrsHevcProfileTierLevel::dumps(SrsHevcProfileTierLevel* ptl)


Can we just do a direct value copy?

*this = *ptl

Or maybe we don't need to use dumps, just do a direct assignment.

sps->ptl.dumps(&profile_tier_level); Change it to... sps->ptl = profile_tier_level;

TRANS_BY_GPT3

trunk/src/kernel/srs_kernel_codec.cpp

chundonglinlin added 2 commits January 27, 2023 23:06

Kernel: Refine complie warnig.

dad5998

SRT: fix stream with NVENC and LARIX.(ossrs#3388)

defe237

chundonglinlin requested review from winlinvip and xiaozhihong January 27, 2023 15:16

chundonglinlin mentioned this pull request Jan 27, 2023

H265: Support HEVC over SRT, RTMP with NVENC and LARIX #3388

Closed

winlinvip reviewed Jan 28, 2023

View reviewed changes

trunk/src/kernel/srs_kernel_codec.cpp Outdated Show resolved Hide resolved

winlinvip mentioned this pull request Jan 28, 2023

Should return error when both HLS and HTTP-TS are enabled #3391

Closed

chundonglinlin added 3 commits February 1, 2023 10:13

H265: remove parse pps_range_extension.

9396723

Kernel: init struct SrsHevcProfileTierLevel.

6cf3672

Kernel: dumps SrsHevcProfileTierLevel.

fe4bac7

winlinvip reviewed Feb 7, 2023

View reviewed changes

trunk/src/kernel/srs_kernel_codec.cpp Show resolved Hide resolved

winlinvip changed the title ~~Kernel: demux stream pps error for NVENC and LARIX.(#3388)~~ Kernel: Fix demux VPS error for NVENC and LARIX.(#3388) Feb 7, 2023

winlinvip changed the title ~~Kernel: Fix demux VPS error for NVENC and LARIX.(#3388)~~ Kernel: Fix demux SPS error for NVENC and LARIX.(#3388) Feb 7, 2023

Kernel: Refine demux hevc pps.

d93d84e

xiaozhihong approved these changes Feb 8, 2023

View reviewed changes

winlinvip linked an issue Feb 8, 2023 that may be closed by this pull request

H265: Support HEVC over SRT, RTMP with NVENC and LARIX #3388

Closed

winlinvip changed the title ~~Kernel: Fix demux SPS error for NVENC and LARIX.(#3388)~~ Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 (#3389) Feb 8, 2023

winlinvip changed the title ~~Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 (#3389)~~ Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 Feb 8, 2023

Merge branch 'develop' into bugfix/fix-demux-codec-pps-error

e6d38b8

Release v6.0.22

366b676

winlinvip assigned chundonglinlin Feb 8, 2023

winlinvip added this to the 6.0 milestone Feb 8, 2023

winlinvip approved these changes Feb 8, 2023

View reviewed changes

winlinvip merged commit 2b0e32a into ossrs:develop Feb 8, 2023

winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22#3389

Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22#3389
winlinvip merged 8 commits intoossrs:developfrom
chundonglinlin:bugfix/fix-demux-codec-pps-error

chundonglinlin commented Jan 27, 2023

Uh oh!

johan149 commented Jan 27, 2023

Uh oh!

chundonglinlin commented Jan 27, 2023 •

edited

Loading

Uh oh!

johan149 commented Jan 27, 2023

Uh oh!

chundonglinlin commented Jan 28, 2023

Uh oh!

Uh oh!

winlinvip commented Jan 28, 2023

Uh oh!

johan149 commented Jan 28, 2023

Uh oh!

johan149 commented Jan 28, 2023 •

edited

Loading

Uh oh!

chundonglinlin commented Jan 30, 2023 •

edited

Loading

Uh oh!

johan149 commented Jan 30, 2023

Uh oh!

winlinvip Feb 7, 2023 •

edited

Loading

Uh oh!

winlinvip Feb 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

chundonglinlin commented Jan 27, 2023

Uh oh!

johan149 commented Jan 27, 2023

Uh oh!

chundonglinlin commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johan149 commented Jan 27, 2023

Uh oh!

chundonglinlin commented Jan 28, 2023

Uh oh!

Uh oh!

winlinvip commented Jan 28, 2023

Uh oh!

johan149 commented Jan 28, 2023

Uh oh!

johan149 commented Jan 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Publish

Publish

Play

Uh oh!

chundonglinlin commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johan149 commented Jan 30, 2023

Uh oh!

winlinvip Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

winlinvip Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

chundonglinlin commented Jan 27, 2023 •

edited

Loading

johan149 commented Jan 28, 2023 •

edited

Loading

chundonglinlin commented Jan 30, 2023 •

edited

Loading

winlinvip Feb 7, 2023 •

edited

Loading

winlinvip Feb 7, 2023 •

edited

Loading