Implement ICE lite ICE-CONTROLLING support#43
Closed
murillo128 wants to merge 11 commits intoossrs:workflowsfrom
Closed
Implement ICE lite ICE-CONTROLLING support#43murillo128 wants to merge 11 commits intoossrs:workflowsfrom
murillo128 wants to merge 11 commits intoossrs:workflowsfrom
Conversation
Member
|
Hi Sergio, thank you for your PR. Could you please provide some background information for this PR in the description? The patch will be generated based on the title and description, and it will be sent via email to the FFmpeg community. Therefore, a detailed description is important for the maintainers to review this PR. |
Author
|
WHIP RFC 9725 mandates support for connecting to a ICE lite media server as per RFC 8445. This patchs detects the SDP signaling of the ICE lite server and adds the ICE-CONTROLLINGattribute the the stun requests as needed. |
3294e09 to
4aa17ba
Compare
The patch is still generated by git config author.
refer to https://www.ffmpeg.org/developer.html#Submitting-patches-1 add header "X-Unsent: 1" add email recipients Signed-off-by: Jack Lau <jacklau1222@qq.com>
All files in the .github directory pertain to CI/CD and should be ignored; they should not be included in the patch.
Signed-off-by: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
2c40a5c to
80db6eb
Compare
Collaborator
|
This patch has been merged Thanks for your support! @murillo128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHIP RFC 9725 mandates support for connecting to a ICE lite media server as per RFC 8445.
This patchs detects the SDP signaling of the ICE lite server and adds the ICE-CONTROLLINGattribute the the stun requests as needed.