Skip to content

Issue with Git submodules #442

@ArisBee

Description

@ArisBee

I've recently got the idea to consolidate Allstar configurations as git submodules. That way configurations can be centralized in several repositories and I can more easily switch between configurations for different collections of repositories.

However, I found that submodules make Allstar crash with the following error logs:

 allstar-6fcd6c87f4-bhctz allstar panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x821f18]                                                                                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar                                                                                                                                                                                                                           │
│ allstar-6fcd6c87f4-bhctz allstar goroutine 60 [running]:                                                                                                                                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar github.com/google/go-github/v50/github.(*RepositoryContent).GetContent(0xc000684c30?)                                                                                                                                     │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/go/pkg/mod/github.com/google/go-github/v50@v50.2.0/github/repos_contents.go:75 +0x18                                                                                                                     │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/config.fetchConfig({0x1a79650, 0xc000859a40}, {0x1a73320, 0xc00050cb90}, {0xc000293270, 0xd}, {0xc000293260, 0xc}, {0x16d12bc, 0xc}, ...)                                                     │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/config/config.go:206 +0x331                                                                                                                                                                  │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/config.getAppConfigs({0x1a79650, 0xc000859a40}, {0x1a73320, 0xc00050cb90}, {0xc000293270, 0xd}, {0xc000293260, 0xc})                                                                          │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/config/config.go:394 +0x3ed                                                                                                                                                                  │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/config.isBotEnabled({0x1a79650, 0xc000859a40}, {0x1a73320, 0xc00050cb90}, {0xc000293270, 0xd}, {0xc000293260, 0xc})                                                                           │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/config/config.go:343 +0x6b                                                                                                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/config.IsBotEnabled({0x1a79650?, 0xc000859a40?}, 0x16d0615?, {0xc000293270?, 0xc000701200?}, {0xc000293260?, 0xd?})                                                                           │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/config/config.go:339 +0x4a                                                                                                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/enforce.runPoliciesOnInstRepos({0x1a79650, 0xc000859a40}, {0xc0002985d0, 0x6, 0x3?}, 0x43a680?, {0x0, 0x0})                                                                                   │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/enforce/enforce.go:188 +0x112                                                                                                                                                                │
│ allstar-6fcd6c87f4-bhctz allstar github.com/ossf/allstar/pkg/enforce.EnforceAll.func1()                                                                                                                                                                    │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/allstar/pkg/enforce/enforce.go:149 +0x1b7                                                                                                                                                                │
│ allstar-6fcd6c87f4-bhctz allstar golang.org/x/sync/errgroup.(*Group).Go.func1()                                                                                                                                                                            │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/go/pkg/mod/golang.org/x/sync@v0.2.0/errgroup/errgroup.go:75 +0x64                                                                                                                                        │
│ allstar-6fcd6c87f4-bhctz allstar created by golang.org/x/sync/errgroup.(*Group).Go                                                                                                                                                                         │
│ allstar-6fcd6c87f4-bhctz allstar     /home/user/go/pkg/mod/golang.org/x/sync@v0.2.0/errgroup/errgroup.go:72 +0xa5  

I've built the container from commit 1ac94c2691ef170086b91ed9f62ec84006201cd1

Any idea how this runtime error could be fixed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions