Skip to content

gz-common6: depend on spdlog#2747

Merged
iche033 merged 3 commits intomasterfrom
common6_spdlog
Aug 29, 2024
Merged

gz-common6: depend on spdlog#2747
iche033 merged 3 commits intomasterfrom
common6_spdlog

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented Aug 26, 2024

to go with: gazebosim/gz-common#615

note: gz-utils3 should pull in spdlog so this may not be necessary.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from scpeters as a code owner August 26, 2024 23:30
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 marked this pull request as draft August 26, 2024 23:37
@scpeters scpeters changed the title gz-common6: Add spdlog dependency gz-common6: depend on spdlog Aug 27, 2024
Copy link
Copy Markdown
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@scpeters
Copy link
Copy Markdown
Member

note: gz-utils3 should pull in spdlog so this may not be necessary.

to clarify, this isn't explicitly needed, because gz-utils3 is pulling it in, but brew is happier when we explicitly depend on libraries that we link against, so I approve merging it

@iche033 iche033 marked this pull request as ready for review August 29, 2024 00:34
@iche033 iche033 merged commit b048ac2 into master Aug 29, 2024
@iche033 iche033 deleted the common6_spdlog branch August 29, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants