Skip to content

ignition-math6: fix build with ruby#1121

Merged
scpeters merged 2 commits intomasterfrom
fix_math6_build_with_ruby
Sep 11, 2020
Merged

ignition-math6: fix build with ruby#1121
scpeters merged 2 commits intomasterfrom
fix_math6_build_with_ruby

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Sep 11, 2020

Fix the build issue with ruby reported in #1120. Start by adding a :build dependency on swig.

@scpeters
ignition-math6: build depend on swig
f9bb282 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Sep 11, 2020

the change in f9bb282 is enough to reproduce the build failure reported in #1120

@scpeters
depend on brew ruby
8d23a5b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters marked this pull request as ready for review September 11, 2020 20:27
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Sep 11, 2020

cc @traversaro

@scpeters scpeters mentioned this pull request Sep 11, 2020
Closed
@traversaro
Copy link
Copy Markdown
Contributor

traversaro commented Sep 11, 2020

cc @traversaro

Thanks @scpeters !

@scpeters scpeters merged commit 45080dc into master Sep 11, 2020
@scpeters scpeters deleted the fix_math6_build_with_ruby branch September 11, 2020 20:45
@scpeters scpeters mentioned this pull request Sep 14, 2020
Merged
@scpeters scpeters mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@traversaro traversaro traversaro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @traversaro