Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
This was referenced Mar 25, 2019
ruffsl
reviewed
Mar 25, 2019
Member
ruffsl
left a comment
There was a problem hiding this comment.
I've commented on the generated files for this review for simplicity: osrf/docker_images#246 (review)
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
740cca3 to
d9e0852
Compare
Contributor
Author
|
thanks for the review 🙇♂️ . I replied inline. |
ruffsl
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate source template into 2: a devel and a source templates as follow:
Devel:
Content
Build Arguments
FROM_IMAGEto use a different base image (e.g building adebian:stretchimage instead of anubuntu:bionicone)Source
The source template will now build on top of the ros2:devel image:
Content
Build Arguments
FROM_IMAGEto override base image (e.g. to useros2:devel-stretchinstead ofosrf/ros2:devel)ROS_DISTROto specify the ROS_DISTRO (otherwise crystal will be set in the env var ROS_DISTRO)RUN_TESTSto runcolcon testafter the build. Disable by default, enabled if arg set to anything but empty stringFAIL_ON_TEST_FAILUREto specify if the image should fail to build on test failures, disabled by default, enabled if arg set to anything but empty string