Conversation
mikaelarguedas
left a comment
There was a problem hiding this comment.
could we generate that from template instead of "hard-coding" all this in the Dockerfile. It looks like most lines are equivalent to the expansion of our already existing templates.
For supporting the testing apt repo we could just add an argument to this template: https://github.com/osrf/docker_templates/blob/8dcaa2592d539a3d715a3886274404eec1bccd66/docker_templates/templates/snippet/setup_ros_sources.Dockerfile.em#L21
I think this Dockerfile cut acrosses two templates, so we'll have to duplicate the template then. |
IMO it is ok to haqve different template as long as they all use the same common snippets. The GPG key incident proved that it was valuable to have a single snippet for setting up the ROS keys rather than having to go modify N Dockerfiles by hand. A template based-approach available on #542 and osrf/docker_templates#97 If we go that route we'd need to update the CI script accordingly (to expand the template on top of looking for upgrades) |
Fixes: #533
Useful for CI, where not all of
osrf/ros2:nightlyis needed, butros:rollingis too behind upstream.CC @SteveMacenski