Update rosdistro to track latest released distro#242
Conversation
ros2/source/images.yaml.em
Outdated
| - --from-paths src | ||
| - --ignore-src | ||
| - --rosdistro bouncy | ||
| - --rosdistro crystal |
There was a problem hiding this comment.
could we make the distro name a parameter that we will use on this line as well as for constructing the URL L49?
There was a problem hiding this comment.
Not sure what you mean. Set ENV ROS_DISTRO and use that to ${} substitute in the githubusercontent.com/ros2/ros2/ URL? I thought we'd just pass the URL from the config outright so that users may point to custom gists and the like.
There was a problem hiding this comment.
It's a nitpick, I'm fine merging as is, I'm mostly trying to look for ways to avoid mismatches in the future
This PR was necessary because there was a mismatch between the distro used by rosdep and the repos file pulled.
If we used a url with a format like https://raw.githubusercontent.com/ros2/ros2/@ros2distro/ros2.repos and rosdep with something like:
install:
- --from-paths src
- --ignore-src
- --rosdistro @ros2distro
We would be ensured that the invocations match in the future.
There was a problem hiding this comment.
looks good to me 👍 thanks for iterating
and have it be used in following setup for consistency
and set repos URL to null to default to https://raw.githubusercontent.com/ros2/ros2/$ROS_DISTRO/ros2.repos
|
with osrf/docker_templates#53 and osrf/docker_templates#56 this should be good to go |
No description provided.