Fix crash when querying carves table with carves larger than 2GB #8732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
requested changes
Dec 17, 2025
Member
zwass
left a comment
There was a problem hiding this comment.
Some minore revisions requested, plus formatting.
Co-authored-by: Zach Wasserman <zach@fleetdm.com>
Co-authored-by: Zach Wasserman <zach@fleetdm.com>
Co-authored-by: Zach Wasserman <zach@fleetdm.com>
zwass
approved these changes
Dec 17, 2025
Member
zwass
left a comment
There was a problem hiding this comment.
Awesome, thank you! Let's merge when CI passes.
lucasmrod
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves fleetdm/fleet#34610
Fixing a bug that was discovered by upload carves >2gb.
It appears that the check for
IsIntwas not sufficient to check for larger integers. byte values of 2gb+ are greater than the max of int32. Switched to int64 to handle this properly.