Fix CI: Remove Login Items plist support from startup_items table #8723
Conversation
Fixes osquery#8718 Remove support for parsing Login Items from com.apple.loginitems.plist, keeping only traditional StartupItems from /System/Library/StartupItems/ and /Library/StartupItems/ directories. This was causing CI failures after recent macOS updates (15.7.2), seemingly due to changes in plist parsing APIs. The functionality seems to be no longer supported, see https://forums.macrumors.com/threads/lost-login-items.2073306/?post=25193038#post-25193038 https://eclecticlight.co/2022/06/21/how-helpers-are-changing-in-ventura/
| }; | ||
|
|
||
| // Path (after /Users/foo) where the login items plist will be found | ||
| const std::string kLoginItemsPlistPath = |
There was a problem hiding this comment.
Hrm....
Reading the ElecticLight post, it talks about ~/Library/Application Support/com.apple.backgroundtaskmanagementagent/backgrounditems.btm which still exists on my machine, but the internet says maybe old.
Internet also says things are moving to /private/var/db/com.apple.backgroundtaskmanagement/BackgroundItems-v*.btm I have 3 versions, and it's not clear to me which is used.
Given our general target of older OSes, I wonder if it makes sense to leave this in, and make it parse whatever file paths we fine?
directionless
left a comment
There was a problem hiding this comment.
I'm not sure why we need this and 8726 -- this seems to be editing files 8726 simply removes. But I'm willing to approve it
|
In #8726 the startup_items.cpp file is renamed to startup_files.mm (and edited). |
Fixes #8718
Remove support for parsing Login Items from com.apple.loginitems.plist, keeping only traditional StartupItems from /System/Library/StartupItems/ and /Library/StartupItems/ directories.
This was causing CI failures after recent macOS updates (15.7.2), seemingly due to changes in plist parsing APIs. The functionality seems to be no longer supported, see
https://forums.macrumors.com/threads/lost-login-items.2073306/?post=25193038#post-25193038 https://eclecticlight.co/2022/06/21/how-helpers-are-changing-in-ventura/