Don't overwrite hardware_version if it has a value #8690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The linux build seemed to have failed for reasons outside of this PR. Can we rerun it? |
Member
|
Kicked off CI again. |
Contributor
Author
|
fatal error: error in backend: IO failure on output stream: No space left on device is the error that the failed test is seeing atm, unless thats a red herring and i'm missing something |
Member
|
Closing and reopening to re-trigger CI on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the previous changes to lenovo systems were made, hardware_version was used to store the old value. The problem is we overwrote that everytime so hardware_version, regardless of value would be reset to "-1".
Only set hardware_version when its not previously set.