Fix build against libaudit >=4.1.1 by removing set_aumessage_mode call #8676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set_aumessage_mode function and its associated constants (MSG_QUIET, DBG_NO) were removed from libaudit in version 4.1.1, breaking the ABI and causing build failures. This function call was redundant as it was setting the library's default behavior (only receiving highest priority audit status messages). Remove the obsolete call to restore compatibility with newer libaudit versions while maintaining identical functionality. The change is backward compatible and will compile successfully with both older libaudit versions (that still contain the function) and newer versions (where it has been removed). Fixes: osquery#8665
The committers listed above are authorized under a signed CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set_aumessage_mode function and its associated constants (MSG_QUIET, DBG_NO) were removed from libaudit in version 4.1.1, breaking the ABI and causing build failures.
This function call was redundant as it was setting the library's default behavior (only receiving highest priority audit status messages). Remove the obsolete call to restore compatibility with newer libaudit versions while maintaining identical functionality.
The change is backward compatible and will compile successfully with both older libaudit versions (that still contain the function) and newer versions (where it has been removed).
Fixes: #8665