-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Implement yara_events table for Windows #8580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| extended_schema(DARWIN, [ | ||
| Column("transaction_id", BIGINT, "ID used during bulk update"), | ||
| ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR didn't make any changes to this column, but I noticed that the code comments indicate it is only ever returned on macOS.
|
I used the following for manual testing of this: osquery command config.json true.yara false.yara foo.yara |
| // NOTE(woodruffw): This will remove nonexistent paths, even if | ||
| // they aren't patterns. For example, C:\foo\bar won't | ||
| // be monitored if it doesn't already exist at table/event | ||
| // creation time. Is that what we want? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmm. That is a good question. My hunch is that we want to let people monitor things that don't exist yet, but I don't know if that's really possible in the bounds of FIM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. This is copied from the ntfs_journal_events table and so shares the same behavior.
Uses the
ntfs_journal_eventspublisher under the hood to get file modifications. Otherwise this is pretty similar to the macOS/Linux implementations.