Skip to content

Fixes in windows helpers #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
directionless merged 1 commit into from
Feb 19, 2025
Merged

Fixes in windows helpers #8549

directionless merged 1 commit into from
Feb 19, 2025

Conversation

@zwass
Copy link
Member

@zwass zwass commented Feb 18, 2025

  • Fix a memory leak in getGroupSidFromUsername (leaked the allocated Sid buffer)
  • Improve Unicode support in psidToString by moving to ConvertSidToStringW

@zwass
Fixes in windows helpers
645617b 
- Fix a memory leak in getGroupSidFromUsername (leaked the allocated Sid buffer)
- Improve Unicode support in psidToString by moving to ConvertSidToStringW
@zwass zwass requested review from a team as code owners February 18, 2025 20:29
Smjert
Smjert approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@Smjert Smjert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@directionless directionless merged commit f40809d into osquery:master Feb 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Smjert Smjert Smjert approved these changes

Assignees

No one assigned

Labels

bug Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zwass @Smjert @directionless