Boost 1.87 compatibility #8533
Boost 1.87 compatibility #8533
Conversation
zwass
left a comment
There was a problem hiding this comment.
The changes make sense to me based on the documented deprecations and removals.
@alessandrogario @Smjert do we need to update the submodule to be building with 1.87?
| client_options_.remote_hostname_->c_str()); | ||
|
|
||
| ssl_sock_->set_verify_callback(boost::asio::ssl::rfc2818_verification( | ||
| ssl_sock_->set_verify_callback(boost::asio::ssl::host_name_verification( |
| { | ||
| boost::system::error_code rc; | ||
| ioc_.run(rc); | ||
| ioc_.reset(); |
|
|
||
| { | ||
| boost::system::error_code rc; | ||
| ioc_.run(rc); |
There was a problem hiding this comment.
zwass
left a comment
There was a problem hiding this comment.
We just discussed in office hours. As far as we can tell, the changes ARE compatible with boost 1.86. @carlsmedstad did we miss something?
Going to go ahead and merge this, but not bumping Boost at this time because we'd want to do some extensive testing.
Don't have time to look into it again, but it's likely I mistakenly thought it wasn't backwards compatible. |
I'm currently rebuilding osquery for Boost 1.87 on Arch Linux and have produced this compatibility patch.
These changes are not backwards compatible with Boost 1.86, but that could be fixed with some
#if BOOST_VERSIONchecks if needed. Let me know if that's the case.Thanks!