Add all platform process based and curl optimized columns #8498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
approved these changes
Dec 16, 2024
| description("Perform an http request and return stats about it.") | ||
| schema([ | ||
| Column("url", TEXT, "The url for the request", required=True, index=True), | ||
| Column("url", TEXT, "The url for the request", required=True, index=True, optimized=True), |
Member
There was a problem hiding this comment.
I see why user_agent isn't optimized. But it could be. 😆 (Eh, not sure it's worth it. Just... things I notice validating your PRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the optimized columns for all platforms. I've split up the optimized changes into multiple PRs to make it easier to validate the table generation methods. I've only added tables where I believe and tested the generate methods support the IN optimization.
I've confirmed that the columns can support these changes by querying the tables with an IN constraint on the optimized columns. I validated the expected results by comparing returned values from osquery 5.13.1 (before IN optimization existed), 5.14.1, and 5.14.1 containing these spec file changes.
With each query I included a NULL, '' (empty string), and some non-existent values in my IN constraint.
Tests were ran on macOS Sequoia:
Version 15.2 Beta (24C5079e), Linux Ubuntu:6.8.0-1018-gcp (Ubuntu 12.3.0-1ubuntu1~22.04), and Windows 11 Pro:10.0.22631.