utils: Optimize default status message constructor #8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents strlen() call on std::string ctor.
…eed" This reverts commit 82ba3f7.
This prevents strlen() call on std::string ctor.
Contributor
|
The proposed change looks good to me. Out of curiosity, do you have a rough idea or example of how much this time this optimization saves? |
directionless
approved these changes
Dec 17, 2024
Contributor
Author
I recall numbers like 0.5% in I guess there exist much more interesting opts, but they require more thorough osq codebase learning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watching
perftool shows large amount ofstrlencalls. The reason is in often default message construction that requires calculation of the constant string "OK" length.Here we move this calculation on program start stage.