Add Darwin platform optimized miscellaneous columns #8484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| schema([ | ||
| Column("domain", TEXT, "Application ID usually in com.name.product format", | ||
| index=True), | ||
| Column("domain", TEXT, "Application ID usually in com.name.product format", index=True, optimized=True), |
Member
There was a problem hiding this comment.
Is username also optimized?
Contributor
Author
There was a problem hiding this comment.
I don't believe so as it appears the username is being set by only the first value from the username context, but the domain context is being iterated and appended to an array:
CFStringRef username = nullptr;
if (context.constraints["username"].exists(EQUALS)) {
auto users = context.constraints["username"].getAll(EQUALS);
username = CFStringCreateWithCString(
kCFAllocatorDefault, (*users.begin()).c_str(), kCFStringEncodingUTF8);
}
CFMutableArrayRef app_map = nullptr;
if (context.constraints["domain"].exists(EQUALS)) {
// If a specific domain is requested, speed up the set of type conversions.
auto domains = context.constraints["domain"].getAll(EQUALS);
app_map = CFArrayCreateMutable(
kCFAllocatorDefault, domains.size(), &kCFTypeArrayCallBacks);
for (const auto& domain : domains) {
auto cf_domain = CFStringCreateWithCString(
kCFAllocatorDefault, domain.c_str(), kCFStringEncodingASCII);
CFArrayAppendValue(app_map, cf_domain);
CFRelease(cf_domain);
}
directionless
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the optimized columns for the Darwin platform. I've split up the optimized changes into multiple PRs to make it easier to validate the table generation methods. I've only added tables where I believe and tested the generate methods support the
INoptimization.I've confirmed that the columns can support these changes by querying the tables with an
INconstraint on the optimized columns. I validated the expected results by comparing returned values from osquery 5.13.1 (beforeINoptimization existed), 5.14.1, and 5.14.1 containing these spec file changes.With each query I included a
NULL,''(empty string), and some non-existent values in myINconstraint.Tests were ran on macOS Sequoia:
Version 15.2 Beta (24C5079e).