Add Darwin platform optimized path columns #8482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
approved these changes
Dec 1, 2024
Member
directionless
left a comment
There was a problem hiding this comment.
I think this is okay. These one do some extra stuff to expand LIKE expressions, but it's probably fine
| schema([ | ||
| Column("name", TEXT, "Name of the Name.app folder"), | ||
| Column("path", TEXT, "Absolute and full Name.app path", index=True), | ||
| Column("path", TEXT, "Absolute and full Name.app path", index=True, optimized=True), |
Member
There was a problem hiding this comment.
The whole Application path accumulator could be less nested, but I think this is correct.
| description("Query file metadata in the Spotlight database.") | ||
| schema([ | ||
| Column("path", TEXT, "Path of the file", required=True), | ||
| Column("path", TEXT, "Path of the file", required=True, optimized=True), |
Member
There was a problem hiding this comment.
I wonder if
osquery/osquery/tables/system/darwin/mdls.mm
Lines 128 to 131 in aa60bbd
| Column("value", TEXT, "String value of most CF types"), | ||
| Column("path", TEXT, "(required) read preferences from a plist", | ||
| required=True), | ||
| Column("path", TEXT, "(required) read preferences from a plist", required=True, optimized=True), |
Member
There was a problem hiding this comment.
Same path expansion for LIKE, but sure
| schema([ | ||
| Column("path", TEXT, "Must provide a path or directory", | ||
| index=True, required=True), | ||
| Column("path", TEXT, "Must provide a path or directory", index=True, optimized=True, required=True), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the optimized columns for the Darwin platform. I've split up the optimized changes into multiple PRs to make it easier to validate the table generation methods. I've only added tables where I believe and tested the generate methods support the
INoptimization.I've confirmed that the columns can support these changes by querying the tables with an
INconstraint on the optimized columns. I validated the expected results by comparing returned values from osquery 5.13.1 (beforeINoptimization existed), 5.14.1, and 5.14.1 containing these spec file changes.With each query I included a
NULL,''(empty string), and some non-existent values in myINconstraint.Tests were ran on macOS Sequoia:
Version 15.2 Beta (24C5079e).